public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: willy@infradead.org, xiang@kernel.org, hch@lst.de,
	linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	hyc.lee@gmail.com
Subject: Re: [PATCH 1/2] iomap: remove over-strict inline data boundary check
Date: Fri, 24 Apr 2026 23:06:35 +0800	[thread overview]
Message-ID: <d9ac4def-a34a-4748-8cc8-d63b460ba8ab@linux.alibaba.com> (raw)
In-Reply-To: <20260423213203.5533-2-linkinjeon@kernel.org>



On 2026/4/24 05:32, Namjae Jeon wrote:
> The current iomap_inline_data_valid() check ensures that inline data
> does not cross a PAGE_SIZE boundary. However, this is an unnecessarily
> strict constraint. If a filesystem provides a valid iomap::inline_data
> pointer and iomap::length, we should trust that the caller has mapped
> sufficient memory for the range, even if it spans across page boundaries.
> Removing this check allows filesystems to point directly to their
> internal data structures without forced page-alignment or additional
> redundant allocations. This remove iomap_inline_data_valid() and
> its callers in buffered and direct I/O paths.
> 
> Suggested-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang

  parent reply	other threads:[~2026-04-24 15:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 21:32 [PATCH 0/2] iomap/ntfs: remove over-strict inline data check and optimize ntfs Namjae Jeon
2026-04-23 21:32 ` [PATCH 1/2] iomap: remove over-strict inline data boundary check Namjae Jeon
2026-04-24 13:30   ` Christoph Hellwig
2026-04-24 15:06   ` Gao Xiang [this message]
2026-04-27 14:14     ` Namjae Jeon
2026-04-23 21:32 ` [PATCH 2/2] ntfs: use direct pointer for inline data to avoid redundant allocation Namjae Jeon
2026-04-24 13:30   ` Christoph Hellwig
2026-04-25 18:37   ` DaeMyung Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9ac4def-a34a-4748-8cc8-d63b460ba8ab@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=brauner@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=hyc.lee@gmail.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox