From: Benjamin Coddington <bcodding@redhat.com>
To: Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
linux-fsdevel@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
devel@driverdev.osuosl.org, Yan Zheng <zyan@redhat.com>,
cluster-devel@redhat.com, Sage Weil <sage@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Christoph Hellwig <hch@infradead.org>,
fuse-devel@lists.sourceforge.net,
Christine Caulfield <ccaulfie@redhat.com>,
v9fs-developer@lists.sourceforge.net,
Ilya Dryomov <idryomov@gmail.com>,
linux-cifs@vger.kernel.org,
Eric Van Hensbergen <ericvh@gmail.com>,
Mark Fasheh <mfasheh@suse.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
David Teigland <teigland@redhat.com>,
Joel Becker <jlbec@evilplan.org>,
ceph-devel@vger.kernel.org, Abdul Hussain <habdul@visteon.com>,
Steven Whitehouse <swhiteho@redhat.com>,
linux-nfs@vger.kernel.org,
Andreas Dilger <andreas.dilger@intel.com>,
Greg K
Subject: [PATCH 1/3] locks: introduce locks_lock_inode_wait()
Date: Thu, 22 Oct 2015 11:35:54 -0400 [thread overview]
Message-ID: <daf0d3941f34438c1fbdc94a5f3a47c2b22f3ee8.1445524157.git.bcodding@redhat.com> (raw)
In-Reply-To: <cover.1445524157.git.bcodding@redhat.com>
In-Reply-To: <cover.1445524157.git.bcodding@redhat.com>
Users of the locks API commonly call either posix_lock_file_wait() or
flock_lock_file_wait() depending upon the lock type. Add a new function
locks_lock_inode_wait() which will check and call the correct function for
the type of lock passed in.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
---
fs/locks.c | 24 ++++++++++++++++++++++++
include/linux/fs.h | 11 +++++++++++
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 2a54c80..68b1784 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1876,6 +1876,30 @@ int flock_lock_inode_wait(struct inode *inode, struct file_lock *fl)
EXPORT_SYMBOL(flock_lock_inode_wait);
/**
+ * locks_lock_inode_wait - Apply a lock to an inode
+ * @inode: inode of the file to apply to
+ * @fl: The lock to be applied
+ *
+ * Apply a POSIX or FLOCK style lock request to an inode.
+ */
+int locks_lock_inode_wait(struct inode *inode, struct file_lock *fl)
+{
+ int res = 0;
+ switch (fl->fl_flags & (FL_POSIX|FL_FLOCK)) {
+ case FL_POSIX:
+ res = posix_lock_inode_wait(inode, fl);
+ break;
+ case FL_FLOCK:
+ res = flock_lock_inode_wait(inode, fl);
+ break;
+ default:
+ BUG();
+ }
+ return res;
+}
+EXPORT_SYMBOL(locks_lock_inode_wait);
+
+/**
* sys_flock: - flock() system call.
* @fd: the file descriptor to lock.
* @cmd: the type of lock to apply.
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 72d8a84..2e283b7 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1059,6 +1059,7 @@ extern int vfs_test_lock(struct file *, struct file_lock *);
extern int vfs_lock_file(struct file *, unsigned int, struct file_lock *, struct file_lock *);
extern int vfs_cancel_lock(struct file *filp, struct file_lock *fl);
extern int flock_lock_inode_wait(struct inode *inode, struct file_lock *fl);
+extern int locks_lock_inode_wait(struct inode *inode, struct file_lock *fl);
extern int __break_lease(struct inode *inode, unsigned int flags, unsigned int type);
extern void lease_get_mtime(struct inode *, struct timespec *time);
extern int generic_setlease(struct file *, long, struct file_lock **, void **priv);
@@ -1177,6 +1178,11 @@ static inline int flock_lock_inode_wait(struct inode *inode,
return -ENOLCK;
}
+static inline int locks_lock_file_wait(struct file *filp, struct file_lock *fl)
+{
+ return -ENOLCK;
+}
+
static inline int __break_lease(struct inode *inode, unsigned int mode, unsigned int type)
{
return 0;
@@ -1225,6 +1231,11 @@ static inline int flock_lock_file_wait(struct file *filp, struct file_lock *fl)
return flock_lock_inode_wait(file_inode(filp), fl);
}
+static inline int locks_lock_file_wait(struct file *filp, struct file_lock *fl)
+{
+ return locks_lock_inode_wait(file_inode(filp), fl);
+}
+
struct fasync_struct {
spinlock_t fa_lock;
int magic;
--
1.7.1
next prev parent reply other threads:[~2015-10-22 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 15:35 [PATCH 0/3] Minor cleanup for locks API Benjamin Coddington
2015-10-22 15:35 ` Benjamin Coddington [this message]
[not found] ` <daf0d3941f34438c1fbdc94a5f3a47c2b22f3ee8.1445524157.git.bcodding-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-22 15:59 ` [PATCH 1/3] locks: introduce locks_lock_inode_wait() kbuild test robot
2015-10-22 16:21 ` Benjamin Coddington
2015-10-22 15:35 ` [PATCH 2/3] Move locks API users to locks_lock_inode_wait() Benjamin Coddington
2015-10-22 15:35 ` [PATCH 3/3] locks: cleanup posix_lock_inode_wait and flock_lock_inode_wait Benjamin Coddington
2015-10-22 16:36 ` [RFC PATCH] locks: posix_lock_inode_wait() can be static kbuild test robot
2015-10-22 16:36 ` [PATCH 3/3] locks: cleanup posix_lock_inode_wait and flock_lock_inode_wait kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daf0d3941f34438c1fbdc94a5f3a47c2b22f3ee8.1445524157.git.bcodding@redhat.com \
--to=bcodding@redhat.com \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=bfields@fieldses.org \
--cc=ccaulfie@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=ericvh@gmail.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=habdul@visteon.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=jlayton@poochiereds.net \
--cc=jlbec@evilplan.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=mfasheh@suse.com \
--cc=miklos@szeredi.hu \
--cc=oleg.drokin@intel.com \
--cc=sage@redhat.com \
--cc=swhiteho@redhat.com \
--cc=teigland@redhat.com \
--cc=trond.myklebust@primarydata.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).