Re: [PATCH v2 0/4] Disable compat cruft on ppc64le v2

Christophe Leroy
2019-08-28T13:08:52Z

On 08/28/2019 10:30 AM, Michal Suchanek wrote:
> With endian switch disabled by default the ppc64le compat supports
> ppc32le only which is something next to nobody has binaries for.
>
> Less code means less bugs so drop the compat stuff.
>
> I am not particularly sure about the best way to resolve the llseek
> situation. I don't see anything in the syscal tables making it
> 32bit-only so I suppose it should be available on 64bit as well.
>
> This is tested on ppc64le top of

Really ?

I get a build failure with ppc64_defconfig + LITTLE_ENDIAN :

CC arch/powerpc/kernel/signal.o
arch/powerpc/kernel/signal.c: In function 'do_signal':
arch/powerpc/kernel/signal.c:250:6: error: unused variable 'is32'
[-Werror=unused-variable]
int is32 = is_32bit_task();
^~~~
cc1: all warnings being treated as errors
make[3]: *** [arch/powerpc/kernel/signal.o] Error 1

Christophe

>
> https://patchwork.ozlabs.org/cover/1153556/
>
> Changes in v2: saner CONFIG_COMPAT ifdefs
>
> Thanks
>
> Michal
>
> Michal Suchanek (4):
> fs: always build llseek.
> powerpc: move common register copy functions from signal_32.c to
> signal.c
> powerpc/64: make buildable without CONFIG_COMPAT
> powerpc/64: Disable COMPAT if littleendian.
>
> arch/powerpc/Kconfig | 2 +-
> arch/powerpc/include/asm/syscall.h | 2 +
> arch/powerpc/kernel/Makefile | 15 ++-
> arch/powerpc/kernel/entry_64.S | 2 +
> arch/powerpc/kernel/signal.c | 146 ++++++++++++++++++++++++++++-
> arch/powerpc/kernel/signal_32.c | 140 ---------------------------
> arch/powerpc/kernel/syscall_64.c | 5 +-
> arch/powerpc/kernel/vdso.c | 4 +-
> arch/powerpc/perf/callchain.c | 14 ++-
> fs/read_write.c | 2 -
> 10 files changed, 177 insertions(+), 155 deletions(-)
>