linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: remove fs.f_write_hint
Date: Mon, 7 Mar 2022 06:52:25 -0700	[thread overview]
Message-ID: <dbd1479d-09fe-aedc-3b43-5bd0cbebe555@kernel.dk> (raw)
In-Reply-To: <20220307104701.607750-3-hch@lst.de>

On 3/7/22 3:47 AM, Christoph Hellwig wrote:
> The value is now completely unused except for reporting it back through
> the F_GET_FILE_RW_HINT ioctl, so remove the value and the two ioctls
> for it.

This commit message could do with some verbiage on why the EINVAL
solution was chosen for the F_{GET,SET}_RW_HINT ioctls.

-- 
Jens Axboe


  reply	other threads:[~2022-03-07 13:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 10:46 remove write hint leftovers Christoph Hellwig
2022-03-07 10:47 ` [PATCH 1/2] fs: remove kiocb.ki_hint Christoph Hellwig
2022-03-07 10:47 ` [PATCH 2/2] fs: remove fs.f_write_hint Christoph Hellwig
2022-03-07 13:52   ` Jens Axboe [this message]
2022-03-13  1:05   ` Al Viro
2022-03-14  8:02     ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2022-03-08  6:05 remove write hint leftovers v2 Christoph Hellwig
2022-03-08  6:05 ` [PATCH 2/2] fs: remove fs.f_write_hint Christoph Hellwig
2022-03-08 22:20   ` Chaitanya Kulkarni
2022-03-08 23:11   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbd1479d-09fe-aedc-3b43-5bd0cbebe555@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).