From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5E4EB64DB for ; Tue, 20 Jun 2023 18:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229843AbjFTSQX (ORCPT ); Tue, 20 Jun 2023 14:16:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbjFTSQV (ORCPT ); Tue, 20 Jun 2023 14:16:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4D7D199 for ; Tue, 20 Jun 2023 11:16:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 620C661348 for ; Tue, 20 Jun 2023 18:16:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 975CBC433CA; Tue, 20 Jun 2023 18:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687284979; bh=8/x6FlS2rdNYsdrdl/GrGUwfaFDrHFmp22LUn9md4KU=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=sRHZ1fNcehSQKWN4Qy7hPxsWp8j86MQlpFDR29VViXdZx16C9KsRetTLX0NZ7cirJ Gw0MuowdqatJWNOqda99oaHFoyxEeQY8dK27+4jVtxhDEmxhs7HOsRmxvg6tB6j9Wh 9ipwHCovf7X3EESXtV9GVyyOyB9X+ssj2f1DOKhfzYPJHy2KgVCkQr9SGl53Umv28Y QznRvHzvwBtt8CjryNmF3FRZybCRxskpTPtZWuHR+WtVh5dEdA4aAGUlKP7MPj2P/Z w6HZ+nvuaUtPzeV/8o8VnlBav3i28l6cxi32t1F3DEZZ5dbchCeEseSlHiGwZg4nSD IcFoP3mHxx/aw== Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 8A0FB27C0054; Tue, 20 Jun 2023 14:16:18 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute3.internal (MEProxy); Tue, 20 Jun 2023 14:16:18 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefhedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet nhguhicunfhuthhomhhirhhskhhifdcuoehluhhtoheskhgvrhhnvghlrdhorhhgqeenuc ggtffrrghtthgvrhhnpedvhfeuvddthfdufffhkeekffetgffhledtleegffetheeugeej ffduhefgteeihfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegrnhguhidomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudduiedu keehieefvddqvdeifeduieeitdekqdhluhhtoheppehkvghrnhgvlhdrohhrgheslhhinh hugidrlhhuthhordhush X-ME-Proxy: Feedback-ID: ieff94742:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1671831A0063; Tue, 20 Jun 2023 14:16:18 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230620180839.oodfav5cz234pph7@moria.home.lan> References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> <20230619104717.3jvy77y3quou46u3@moria.home.lan> <20230619191740.2qmlza3inwycljih@moria.home.lan> <5ef2246b-9fe5-4206-acf0-0ce1f4469e6c@app.fastmail.com> <20230620180839.oodfav5cz234pph7@moria.home.lan> Date: Tue, 20 Jun 2023 11:15:25 -0700 From: "Andy Lutomirski" To: "Kent Overstreet" Cc: "Mark Rutland" , "Linux Kernel Mailing List" , linux-fsdevel@vger.kernel.org, "linux-bcachefs@vger.kernel.org" , "Kent Overstreet" , "Andrew Morton" , "Uladzislau Rezki" , "hch@infradead.org" , linux-mm@kvack.org, "Kees Cook" , "the arch/x86 maintainers" Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 20, 2023, at 11:08 AM, Kent Overstreet wrote: > On Tue, Jun 20, 2023 at 10:42:02AM -0700, Andy Lutomirski wrote: >> Code is either correct, and comes with an explanation as to how it is >> correct, or it doesn't go in. Saying that something is like BPF is >> not an explanation as to how it's correct. Saying that someone has >> not come up with the chain of events that causes a mere violation of >> architecture rules to actual incorrect execution is not an explanation >> as to how something is correct. > > No, I'm saying your concerns are baseless and too vague to address. If you don't address them, the NAK will stand forever, or at least until a different group of people take over x86 maintainership. That's fine with me. I'm generally pretty happy about working with people to get their Linux code right. But no one is obligated to listen to me. > >> text_poke() by itself is *not* the proper API, as discussed. It >> doesn't serialize adequately, even on x86. We have text_poke_sync() >> for that. > > Andy, I replied explaining the difference between text_poke() and > text_poke_sync(). It's clear you have no idea what you're talking about, > so I'm not going to be wasting my time on further communications with > you. No problem. Then your x86 code will not be merged upstream. Best of luck with the actual filesystem parts! --Andy