From: Shuah Khan <skhan@linuxfoundation.org>
To: Seth Forshee <sforshee@kernel.org>
Cc: shuah@kernel.org, brauner@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/mount_setattr: fix redefine struct mount_attr build error
Date: Tue, 14 Feb 2023 16:37:05 -0700 [thread overview]
Message-ID: <dda181d1-8a5b-adb4-6665-016f50e51487@linuxfoundation.org> (raw)
In-Reply-To: <Y+vzB1OTXr+zTCV7@do-x1extreme>
On 2/14/23 13:45, Seth Forshee wrote:
> On Tue, Feb 14, 2023 at 10:10:00AM -0700, Shuah Khan wrote:
>>>
>>
>> The header search looks up system headers followed by installed headers in
>> the repo (both in-tree and out-of-tree builds). kselftest builds do depend
>> on headers_install. Did you building after running headers_install?
>
> I wasn't aware they depend on headers_install. Why doesn't
> Documentation/dev-tools/kselftest.rst mention this in the section that
> describes how to run tests?
>
It ahs always been a dependency. If you were to compile from the
main (root) Makefile as below - headers_install get done before
test compile:
make kselftest-all TARGETS=mount_setattr
> It seems what I really need to fix the build is to include
> linux/mount.h, which works for me with or without headers_install,
> because I have the struct in /usr/include/linux/mount.h. And I suppose
> the makefile should use KHDR_INCLUDES. So maybe the changes below should
> also be included.
>
Yes. Makefile change to use KHDR_INCLUDES is already done. Please
take a look at linux-kselftest next - this was done as part of a
tree-wide change.
If including linux/mount.h is thr correct solution, please send me
the patch on top of linux-kselftest next and I will pull it in.
> However I know Christian has said that there are challenges with
> including the mount headers. He wrote this test, so I'd like to hear his
> thoughts about adding the include. He's on vacation this week though.
>
Sounds good.
thanks,
-- Shuah
next prev parent reply other threads:[~2023-02-14 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 18:31 [PATCH] selftests/mount_setattr: fix redefine struct mount_attr build error Shuah Khan
2023-02-13 23:50 ` Seth Forshee
2023-02-14 17:10 ` Shuah Khan
2023-02-14 20:45 ` Seth Forshee
2023-02-14 23:37 ` Shuah Khan [this message]
2023-03-13 9:47 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dda181d1-8a5b-adb4-6665-016f50e51487@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sforshee@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox