linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	netdev@vger.kernel.org,
	"davem@davemloft.net" <davem@davemloft.net>,
	eric.dumazet@gmail.com
Subject: Re: [PATCH] fs/epoll: Enable non-blocking busypoll with epoll timeout of 0
Date: Wed, 24 Jun 2020 09:32:22 -0700	[thread overview]
Message-ID: <de6bf72d-d4fd-9a62-c082-c82179d1f4fe@intel.com> (raw)
In-Reply-To: <1592590409-35439-1-git-send-email-sridhar.samudrala@intel.com>

Adding Dave, Eric for review and see if we can get this in via net-next
as this is mainly useful for networking workloads doing busypoll.

Thanks
Sridhar

On 6/19/2020 11:13 AM, Sridhar Samudrala wrote:
> This patch triggers non-blocking busy poll when busy_poll is enabled and
> epoll is called with a timeout of 0 and is associated with a napi_id.
> This enables an app thread to go through napi poll routine once by calling
> epoll with a 0 timeout.
> 
> poll/select with a 0 timeout behave in a similar manner.
> 
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> ---
>   fs/eventpoll.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
> index 12eebcdea9c8..5f55078d6381 100644
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -1847,6 +1847,19 @@ static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events,
>   		eavail = ep_events_available(ep);
>   		write_unlock_irq(&ep->lock);
>   
> +		/*
> +		 * Trigger non-blocking busy poll if timeout is 0 and there are
> +		 * no events available. Passing timed_out(1) to ep_busy_loop
> +		 * will make sure that busy polling is triggered only once and
> +		 * only if sysctl.net.core.busy_poll is set to non-zero value.
> +		 */
> +		if (!eavail) {
> +			ep_busy_loop(ep, timed_out);
> +			write_lock_irq(&ep->lock);
> +			eavail = ep_events_available(ep);
> +			write_unlock_irq(&ep->lock);
> +		}
> +
>   		goto send_events;
>   	}
>   
> 

  reply	other threads:[~2020-06-24 16:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 18:13 [PATCH] fs/epoll: Enable non-blocking busypoll with epoll timeout of 0 Sridhar Samudrala
2020-06-24 16:32 ` Samudrala, Sridhar [this message]
2020-06-24 16:49   ` Eric Dumazet
2020-06-24 18:25     ` Samudrala, Sridhar
  -- strict thread matches above, loose matches on Subject: below --
2020-06-19 18:00 Sridhar Samudrala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de6bf72d-d4fd-9a62-c082-c82179d1f4fe@intel.com \
    --to=sridhar.samudrala@intel.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).