Re: [PATCH] fscrypt: make fscrypt_operations.key_prefix a string

[Richard Weinberger <richard@nod.at>]

Am 05.01.2017 um 22:51 schrieb Eric Biggers:
> From: Eric Biggers <ebiggers@google.com>
> 
> There was an unnecessary amount of complexity around requesting the
> filesystem-specific key prefix.  It was unclear why; perhaps it was
> envisioned that different instances of the same filesystem type could
> use different key prefixes, or that key prefixes could be binary.

This complexity was also never clear to me.

> However, neither of those things were implemented or really make sense
> at all.  So simplify the code by making key_prefix a const char *.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  fs/crypto/keyinfo.c      | 31 +++++++++++--------------------
>  fs/ext4/ext4.h           | 11 -----------
>  fs/ext4/super.c          | 13 +------------
>  fs/f2fs/f2fs.h           |  9 ---------
>  fs/f2fs/super.c          | 14 +-------------
>  fs/ubifs/crypto.c        | 11 +----------
>  include/linux/fscrypto.h |  2 +-
>  7 files changed, 15 insertions(+), 76 deletions(-)

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard