From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1AEC433EF for ; Tue, 28 Jun 2022 12:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345002AbiF1MU6 (ORCPT ); Tue, 28 Jun 2022 08:20:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344426AbiF1MU5 (ORCPT ); Tue, 28 Jun 2022 08:20:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 370982ED5E for ; Tue, 28 Jun 2022 05:20:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C72D861369 for ; Tue, 28 Jun 2022 12:20:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50B04C3411D; Tue, 28 Jun 2022 12:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656418856; bh=RzBfVy028WaljwYPBi0cXZ9CpNyOKxLVU4vztcx9AWk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=nZhuj3iQaImZ07TXA8eDn0Fcy7JyYpw35DHdmPNMLmamOo7+rpGRj2hHQqxUz0Xyh VEeIik+4fMU/5rK2bJniEMvy6MLDnnLHAz7m11uJ3UJbFpII66sJEtYBinc2+zjphb j8sT+RhiLr+HFd61zaXR0g0CkR8tVbXXk05pmkX3t//Xz6q1YXtQJq0aacemGBiNsd cxsBjFBQeiE8+G4Ic6nMWbHOz3rat4sd6pVhptuUfXVRCCnZaW5sGQBwsJ3y+Xnloz VZsVLs2ZpIiF5y5fIDKVzBYALd4A/Jj46NyImYUYAHXdjO4vK3713qR43jFxR/76S9 LzInxCMlFH6kg== Message-ID: Subject: Re: [PATCH 41/44] ceph: switch the last caller of iov_iter_get_pages_alloc() From: Jeff Layton To: Al Viro , linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jens Axboe , Christoph Hellwig , Matthew Wilcox , David Howells , Dominique Martinet , Christian Brauner Date: Tue, 28 Jun 2022 08:20:54 -0400 In-Reply-To: <20220622041552.737754-41-viro@zeniv.linux.org.uk> References: <20220622041552.737754-1-viro@zeniv.linux.org.uk> <20220622041552.737754-41-viro@zeniv.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, 2022-06-22 at 05:15 +0100, Al Viro wrote: > here nothing even looks at the iov_iter after the call, so we couldn't > care less whether it advances or not. >=20 > Signed-off-by: Al Viro > --- > fs/ceph/addr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 6dee88815491..3c8a7cf19e5d 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -329,7 +329,7 @@ static void ceph_netfs_issue_read(struct netfs_io_sub= request *subreq) > =20 > dout("%s: pos=3D%llu orig_len=3D%zu len=3D%llu\n", __func__, subreq->st= art, subreq->len, len); > iov_iter_xarray(&iter, READ, &rreq->mapping->i_pages, subreq->start, le= n); > - err =3D iov_iter_get_pages_alloc(&iter, &pages, len, &page_off); > + err =3D iov_iter_get_pages_alloc2(&iter, &pages, len, &page_off); > if (err < 0) { > dout("%s: iov_ter_get_pages_alloc returned %d\n", __func__, err); > goto out; There are some coming changes to make this code use an iter passed in as part of the subreq, at which point we will need to advance this anyway. Reviewed-by: Jeff Layton