From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com [35.158.23.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F25C8386C1B; Fri, 6 Mar 2026 12:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.158.23.94 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772801345; cv=none; b=iNCDpVIUJ6WSL0sDOFBgGygrLSm3SkN/iH0Yy8SZwkM9sywAuOG0bSwh7GuHxzQBNSUdM2yNonUfB1z07uQDDKkqKsjYsZq0/KOvh2wEgAszbJfFWG0SWUJpcr2L2R6MOQL91EzxmvAtEw4smvabinh4A8jMMltxCf/1pmyD3p8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772801345; c=relaxed/simple; bh=SEJyKJrVVXhDtXAdpvn4t8m1VfN78VfvgyjiSzZ0ulU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=IRiLN1o8ECNGIFg+OOtJ4nIi8JfT2kSbFvyJwQOVBwfHQ/7xokwCwsoEHdHTqr5PvZgEwjuiVmCU1g1TO9CJugN+s6xE+llak5/FkOplcPy4ufCR39E6oLb9KeRUZyWklnxahwfI1EuCadwCQRkStzMwm5pViLL5CzJUfviLvxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=qvYKJwz+; arc=none smtp.client-ip=35.158.23.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="qvYKJwz+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1772801344; x=1804337344; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=CYNmKAIYLANzYIpa2I/xdJ5H5+KpVyo7DXkoAl0aOOw=; b=qvYKJwz+MIXBzWXkQxpb8XEYScpB96bwjn/ktEKnW9qYCUq4PKRrmvBe Fr23uX6st2XtTu7yhL3ORd6nRtkzEqeQegU574o0n2S2IeWwzApEEy1Mh YYV68QRlsxQdTUDZ1uAmC9PrRi6vRD8/VhL2BpS7lX8mjd6iJYBGMs6UZ ppHgf5S7MbRp9ovHsn5oA0NSPk+GzkZJrGQYgPaZseSdUIrnlyE3719P9 qnRuCcjUSw6jkQV/lph67HCCuEwXKSxWgmlOfC+UMhtyhqVFD8vMLxnua WyDmERE3r/Z1e6tX/lmM+IBpEGs+l1ixV/+poA1xeQ0NEK8YE3/bLvVTn Q==; X-CSE-ConnectionGUID: tyGyI/djTA6pJNxUDqgzyw== X-CSE-MsgGUID: I8l7qS2EQbS3LpyAB/W9cA== X-IronPort-AV: E=Sophos;i="6.23,104,1770595200"; d="scan'208";a="10425965" Received: from ip-10-6-6-97.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.6.97]) by internal-fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2026 12:48:59 +0000 Received: from EX19MTAEUC002.ant.amazon.com [54.240.197.236:2354] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.24.155:2525] with esmtp (Farcaster) id e48020fd-6821-4580-89f4-8de4f43de7f2; Fri, 6 Mar 2026 12:48:58 +0000 (UTC) X-Farcaster-Flow-ID: e48020fd-6821-4580-89f4-8de4f43de7f2 Received: from EX19D005EUB003.ant.amazon.com (10.252.51.31) by EX19MTAEUC002.ant.amazon.com (10.252.51.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 6 Mar 2026 12:48:57 +0000 Received: from [192.168.2.180] (10.106.83.26) by EX19D005EUB003.ant.amazon.com (10.252.51.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 6 Mar 2026 12:48:52 +0000 Message-ID: Date: Fri, 6 Mar 2026 12:48:51 +0000 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v10 02/15] set_memory: add folio_{zap, restore}_direct_map helpers To: "David Hildenbrand (Arm)" , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "lorenzo.stoakes@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "Jonathan.Cameron@huawei.com" , "Liam.Howlett@oracle.com" , "urezki@gmail.com" , "zhengqi.arch@bytedance.com" , "gerald.schaefer@linux.ibm.com" , "jiayuan.chen@shopee.com" , "lenb@kernel.org" , "osalvador@suse.de" , "pavel@kernel.org" , "rafael@kernel.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20260126164445.11867-1-kalyazin@amazon.com> <20260126164445.11867-3-kalyazin@amazon.com> Content-Language: en-US From: Nikita Kalyazin In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D015EUA002.ant.amazon.com (10.252.50.219) To EX19D005EUB003.ant.amazon.com (10.252.51.31) On 05/03/2026 17:34, David Hildenbrand (Arm) wrote: > On 1/26/26 17:47, Kalyazin, Nikita wrote: >> From: Nikita Kalyazin >> >> These allow guest_memfd to remove its memory from the direct map. >> Only implement them for architectures that have direct map. >> In folio_zap_direct_map(), flush TLB on architectures where >> set_direct_map_valid_noflush() does not flush it internally. > > "Let's provide folio_{zap,restore}_direct_map helpers as preparation for > supporting removal of the direct map for guest_memfd folios. ... Will update, thanks. > >> >> The new helpers need to be accessible to KVM on architectures that >> support guest_memfd (x86 and arm64). Since arm64 does not support >> building KVM as a module, only export them on x86. >> >> Direct map removal gives guest_memfd the same protection that >> memfd_secret does, such as hardening against Spectre-like attacks >> through in-kernel gadgets. > > Would it be possible to convert mm/secretmem.c as well? > > There, we use > > set_direct_map_invalid_noflush(folio_page(folio, 0)); > > and > > set_direct_map_default_noflush(folio_page(folio, 0)); > > Which is a bit different to below code. At least looking at the x86 > variants, I wonder why we don't simply use set_direct_map_valid_noflush(). > > > If so, can you add a patch to do the conversion, pleeeeassse ? :) Absolutely! > >> >> Reviewed-by: Ackerley Tng >> Signed-off-by: Nikita Kalyazin >> --- >> arch/arm64/include/asm/set_memory.h | 2 ++ >> arch/arm64/mm/pageattr.c | 12 ++++++++++++ >> arch/loongarch/include/asm/set_memory.h | 2 ++ >> arch/loongarch/mm/pageattr.c | 12 ++++++++++++ >> arch/riscv/include/asm/set_memory.h | 2 ++ >> arch/riscv/mm/pageattr.c | 12 ++++++++++++ >> arch/s390/include/asm/set_memory.h | 2 ++ >> arch/s390/mm/pageattr.c | 12 ++++++++++++ >> arch/x86/include/asm/set_memory.h | 2 ++ >> arch/x86/mm/pat/set_memory.c | 20 ++++++++++++++++++++ >> include/linux/set_memory.h | 10 ++++++++++ >> 11 files changed, 88 insertions(+) >> >> diff --git a/arch/arm64/include/asm/set_memory.h b/arch/arm64/include/asm/set_memory.h >> index c71a2a6812c4..49fd54f3c265 100644 >> --- a/arch/arm64/include/asm/set_memory.h >> +++ b/arch/arm64/include/asm/set_memory.h >> @@ -15,6 +15,8 @@ int set_direct_map_invalid_noflush(const void *addr); >> int set_direct_map_default_noflush(const void *addr); >> int set_direct_map_valid_noflush(const void *addr, unsigned long numpages, >> bool valid); >> +int folio_zap_direct_map(struct folio *folio); >> +int folio_restore_direct_map(struct folio *folio); >> bool kernel_page_present(struct page *page); >> >> int set_memory_encrypted(unsigned long addr, int numpages); >> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c >> index e2bdc3c1f992..0b88b0344499 100644 >> --- a/arch/arm64/mm/pageattr.c >> +++ b/arch/arm64/mm/pageattr.c >> @@ -356,6 +356,18 @@ int set_direct_map_valid_noflush(const void *addr, unsigned long numpages, >> return set_memory_valid((unsigned long)addr, numpages, valid); >> } >> >> +int folio_zap_direct_map(struct folio *folio) >> +{ >> + return set_direct_map_valid_noflush(folio_address(folio), >> + folio_nr_pages(folio), false); >> +} >> + >> +int folio_restore_direct_map(struct folio *folio) >> +{ >> + return set_direct_map_valid_noflush(folio_address(folio), >> + folio_nr_pages(folio), true); >> +} > > Is there a good reason why we cannot have two generic inline functions > that simply call set_direct_map_valid_noflush() ? > > Is it because of some flushing behavior? (which we could figure out) Yes, on x86 we need an explicit flush. Other architectures deal with it internally. Do you propose a bespoke implementation for x86 and a "generic" one for others? > > > In particular, a single set of functions could have a beautiful > centralized kerneldoc, right?! :) > > -- > Cheers, > > David