From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Warren Turkal" Subject: Re: [PATCH] Fix journal detection on HFS+. Date: Fri, 7 Nov 2008 10:01:07 -0800 Message-ID: References: <20081105140937.GA27438@infradead.org> <1225957463-29519-1-git-send-email-wt@penguintechs.org> <1225957463-29519-2-git-send-email-wt@penguintechs.org> <1225957463-29519-3-git-send-email-wt@penguintechs.org> <20081107083250.GA29200@logfs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel , "Roman Zippel" To: "=?ISO-8859-1?Q?J=F6rn_Engel?=" Return-path: Received: from rv-out-0506.google.com ([209.85.198.239]:51211 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752356AbYKGSBI convert rfc822-to-8bit (ORCPT ); Fri, 7 Nov 2008 13:01:08 -0500 Received: by rv-out-0506.google.com with SMTP id k40so1366196rvb.1 for ; Fri, 07 Nov 2008 10:01:07 -0800 (PST) In-Reply-To: <20081107083250.GA29200@logfs.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 7, 2008 at 12:32 AM, J=F6rn Engel wrote: > On Wed, 5 November 2008 23:44:23 -0800, Warren Turkal wrote: >> >> -hfsplus-objs :=3D super.o options.o inode.o ioctl.o extents.o catal= og.o dir.o btree.o \ >> - bnode.o brec.o bfind.o tables.o unicode.o wrapper.o bi= tmap.o part_tbl.o >> +hfsplus-objs :=3D super.o options.o inode.o ioctl.o extents.o catal= og.o dir.o \ >> + btree.o bnode.o brec.o bfind.o tables.o unicode.o wrap= per.o \ >> + bitmap.o part_tbl.o journal.o > > Didn't check-read your patch? Remove, please. I am sorry, but I don't understand this comment. What is check-read? Do you want me to remove the journal.o from the hfsplus-objs line? >> diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h >> index f027a90..9018d2d 100644 >> --- a/fs/hfsplus/hfsplus_fs.h >> +++ b/fs/hfsplus/hfsplus_fs.h >> @@ -421,4 +421,6 @@ static inline struct hfsplus_inode_info *HFSPLUS= _I(struct inode *inode) >> >> #define kdev_t_to_nr(x) (x) >> >> +bool hfsp_vol_has_journal(struct hfsplus_vh *vhdr); >> + > > The function is only ever used in super.c. Just leave it in the same > file and make it static. Okay...will do. wt -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html