From: "Warren Turkal" <wt@penguintechs.org>
To: "Jörn Engel" <joern@logfs.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"Roman Zippel" <zippel@linux-m68k.org>
Subject: Re: [PATCH] Fix journal detection on HFS+.
Date: Sat, 8 Nov 2008 21:27:30 -0800 [thread overview]
Message-ID: <e37d376a0811082127r68f6266h76e1f9e0b2155be5@mail.gmail.com> (raw)
In-Reply-To: <20081108110953.GA9216@logfs.org>
Is everything looking ok at this point?
wt
On Sat, Nov 8, 2008 at 3:09 AM, Jörn Engel <joern@logfs.org> wrote:
> On Fri, 7 November 2008 10:01:07 -0800, Warren Turkal wrote:
>>
>> I am sorry, but I don't understand this comment. What is check-read?
>> Do you want me to remove the journal.o from the hfsplus-objs line?
>
> Honestly, I didn't even notice you created a new file for that one
> function. This hunk looked like something completely unrelated -
> reformatting can hide functional changes.
>
> /me whistles innocently
>
> Jörn
>
> --
> Measure. Don't tune for speed until you've measured, and even then
> don't unless one part of the code overwhelms the rest.
> -- Rob Pike
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-09 5:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 8:00 hfsplus journal detection Warren Turkal
2008-11-05 8:00 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-05 8:00 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-05 10:40 ` Jörn Engel
2008-11-05 14:09 ` Christoph Hellwig
2008-11-06 7:44 ` hfsplus journal detection - next try Warren Turkal
2008-11-06 7:44 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-06 7:44 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-07 8:32 ` Jörn Engel
2008-11-07 18:01 ` Warren Turkal
2008-11-08 11:09 ` Jörn Engel
2008-11-09 5:27 ` Warren Turkal [this message]
2008-11-09 11:02 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2008-11-08 8:55 hfsplus journal detection - try 3 Warren Turkal
2008-11-08 8:55 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-08 8:55 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-11 20:56 hfsplus journal detection - try 4 Warren Turkal
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-19 22:51 ` Andrew Morton
2008-11-20 1:01 ` Warren Turkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e37d376a0811082127r68f6266h76e1f9e0b2155be5@mail.gmail.com \
--to=wt@penguintechs.org \
--cc=joern@logfs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).