From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Warren Turkal" Subject: Re: [PATCH] Fix journal detection on HFS+. Date: Sat, 8 Nov 2008 21:27:30 -0800 Message-ID: References: <20081105140937.GA27438@infradead.org> <1225957463-29519-1-git-send-email-wt@penguintechs.org> <1225957463-29519-2-git-send-email-wt@penguintechs.org> <1225957463-29519-3-git-send-email-wt@penguintechs.org> <20081107083250.GA29200@logfs.org> <20081108110953.GA9216@logfs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel , "Roman Zippel" To: "=?ISO-8859-1?Q?J=F6rn_Engel?=" Return-path: Received: from rv-out-0506.google.com ([209.85.198.238]:7918 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbYKIF1c convert rfc822-to-8bit (ORCPT ); Sun, 9 Nov 2008 00:27:32 -0500 Received: by rv-out-0506.google.com with SMTP id k40so1954070rvb.1 for ; Sat, 08 Nov 2008 21:27:30 -0800 (PST) In-Reply-To: <20081108110953.GA9216@logfs.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Is everything looking ok at this point? wt On Sat, Nov 8, 2008 at 3:09 AM, J=F6rn Engel wrote: > On Fri, 7 November 2008 10:01:07 -0800, Warren Turkal wrote: >> >> I am sorry, but I don't understand this comment. What is check-read? >> Do you want me to remove the journal.o from the hfsplus-objs line? > > Honestly, I didn't even notice you created a new file for that one > function. This hunk looked like something completely unrelated - > reformatting can hide functional changes. > > /me whistles innocently > > J=F6rn > > -- > Measure. Don't tune for speed until you've measured, and even then > don't unless one part of the code overwhelms the rest. > -- Rob Pike > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html