From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Warren Turkal" Subject: Re: [PATCH] Fix header include. Date: Wed, 19 Nov 2008 18:30:54 -0800 Message-ID: References: <1226437008-14247-1-git-send-email-wt@penguintechs.org> <1226437008-14247-2-git-send-email-wt@penguintechs.org> <1226437008-14247-3-git-send-email-wt@penguintechs.org> <1226437008-14247-4-git-send-email-wt@penguintechs.org> <20081119145140.32828903.akpm@linux-foundation.org> <20081120004150.GA22395@cynthia.pants.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Andrew Morton" , linux-fsdevel@vger.kernel.org, zippel@linux-m68k.org To: "Brad Boyer" Return-path: Received: from rv-out-0506.google.com ([209.85.198.233]:1651 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769AbYKTCaz (ORCPT ); Wed, 19 Nov 2008 21:30:55 -0500 Received: by rv-out-0506.google.com with SMTP id k40so236231rvb.1 for ; Wed, 19 Nov 2008 18:30:54 -0800 (PST) In-Reply-To: <20081120004150.GA22395@cynthia.pants.nu> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: I just submitted a patchset with more detailed commit comments.. It's the same change wrapped in a, hopefully, prettier candy coating. wt On Wed, Nov 19, 2008 at 4:41 PM, Brad Boyer wrote: > On Wed, Nov 19, 2008 at 02:51:40PM -0800, Andrew Morton wrote: >> On Tue, 11 Nov 2008 12:56:48 -0800 >> Warren Turkal wrote: >> > @@ -15,12 +15,12 @@ >> > #include >> > #include >> > >> > +#include "hfsplus_fs.h" >> > + >> > static struct inode *hfsplus_alloc_inode(struct super_block *sb); >> > static void hfsplus_destroy_inode(struct inode *inode); >> > static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr); >> > >> > -#include "hfsplus_fs.h" >> > - >> > static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr) >> > { >> > return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) && >> >> again: what was wrong with the old code?? > > I just realized what you were asking after I sent my other reply. The > include needs to move so 'struct hfsplus_vh' is declared before the > function prototype. That happens in hfsplus_fs.h. > > My apologies for the noise, although I stand by my statement that I > have no intention of actively maintaining this code myself. > >> If it was causing some compilation problem then please quote the compiler >> output in the changelog. > > The original submitter would need to include the actual compiler output. > > Brad Boyer > flar@allandria.com > >