From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Warren Turkal" Subject: Re: [PATCH 2/2] Fix journal detection on HFS+. Date: Thu, 20 Nov 2008 09:02:26 -0800 Message-ID: References: <1227147960-32355-1-git-send-email-wt@penguintechs.org> <1227147960-32355-2-git-send-email-wt@penguintechs.org> <1227147960-32355-3-git-send-email-wt@penguintechs.org> <20081120112903.GB30887@logfs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Andrew Morton" , linux-fsdevel@vger.kernel.org To: "=?ISO-8859-1?Q?J=F6rn_Engel?=" Return-path: Received: from rv-out-0506.google.com ([209.85.198.235]:6634 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757198AbYKTRC1 convert rfc822-to-8bit (ORCPT ); Thu, 20 Nov 2008 12:02:27 -0500 Received: by rv-out-0506.google.com with SMTP id k40so541386rvb.1 for ; Thu, 20 Nov 2008 09:02:26 -0800 (PST) In-Reply-To: <20081120112903.GB30887@logfs.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Nov 20, 2008 at 3:29 AM, J=F6rn Engel wrote: > On Wed, 19 November 2008 18:26:00 -0800, Warren Turkal wrote: >> >> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c >> index eb74531..4f00a84 100644 >> --- a/fs/hfsplus/super.c >> +++ b/fs/hfsplus/super.c >> @@ -15,10 +15,17 @@ >> #include >> #include >> >> +#include "hfsplus_fs.h" >> + >> static struct inode *hfsplus_alloc_inode(struct super_block *sb); >> static void hfsplus_destroy_inode(struct inode *inode); >> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr); > > Sorry for not noticing this before. The function declaration is > unnecessary. There are no callers before the actual function > definition, which is just below. I will have to get rid of this when I get home tonight. >> -#include "hfsplus_fs.h" >> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr) >> +{ >> + return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) = && >> + vhdr->journal_info_block); >> +} > > You're going through a huge number of iterations for such a simple > change. Others would have lost patience some time ago. :( Bah...I'm playing in someone else's sandbox, and I have a lot to learn around here. I figure I probably shouldn't second guess the more experienced folks. wt -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html