From: "Warren Turkal" <wt@penguintechs.org>
To: "Roman Zippel" <zippel@linux-m68k.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix journal detection on HFS+.
Date: Tue, 25 Nov 2008 15:45:56 -0800 [thread overview]
Message-ID: <e37d376a0811251545tab3dc74xf904844f251f88af@mail.gmail.com> (raw)
In-Reply-To: <200811230552.02221.zippel@linux-m68k.org>
On Sat, Nov 22, 2008 at 8:52 PM, Roman Zippel <zippel@linux-m68k.org> wrote:
> I'm curious how common it is to have the journal bit set but no journal block,
> I haven't seen this case so far.
It's so uncommon that the technote for HFS+ doesn't mention it.
However, I did find [1], and it's (c) by Apple. Look at the comment at
[2] to see what tipped me off.
> IMO more useful would be to read the journal block and check if there is
> anything that needs to be replayed.
> If you're interested in a second step you could replay the journal, it's not
> that difficult to do, it's pretty much just copying blocks around.
I am actually looking into doing the journal replaying, but i haven't
gotten around to it yet.
[1]http://fxr.watson.org/fxr/source/bsd/hfs/hfs_format.h?v=xnu-1228#L626
[2]http://fxr.watson.org/fxr/source/bsd/hfs/hfs_format.h?v=xnu-1228#L633
wt
next prev parent reply other threads:[~2008-11-25 23:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 4:01 [PATCH 0/2] HFS+ journal improvement - take 6 Warren Turkal
2008-11-21 4:01 ` [PATCH 1/2] Identify journal info block in volume header Warren Turkal
2008-11-21 4:01 ` [PATCH 2/2] Fix journal detection on HFS+ Warren Turkal
2008-11-23 4:52 ` Roman Zippel
2008-11-25 23:45 ` Warren Turkal [this message]
2008-11-27 16:21 ` Roman Zippel
2008-12-01 10:28 ` Warren Turkal
2008-12-01 14:27 ` Roman Zippel
2008-12-01 14:49 ` Roman Zippel
-- strict thread matches above, loose matches on Subject: below --
2008-11-20 2:25 [PATCH 0/2] HFS+ journal improvement - take 5 Warren Turkal
2008-11-20 2:25 ` [PATCH 1/2] Identify journal info block in volume header Warren Turkal
2008-11-20 2:26 ` [PATCH 2/2] Fix journal detection on HFS+ Warren Turkal
2008-11-20 11:29 ` Jörn Engel
2008-11-20 17:02 ` Warren Turkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e37d376a0811251545tab3dc74xf904844f251f88af@mail.gmail.com \
--to=wt@penguintechs.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).