From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Warren Turkal" Subject: Re: [PATCH 2/2] Fix journal detection on HFS+. Date: Tue, 25 Nov 2008 15:45:56 -0800 Message-ID: References: <1227240087-29413-1-git-send-email-wt@penguintechs.org> <1227240087-29413-2-git-send-email-wt@penguintechs.org> <1227240087-29413-3-git-send-email-wt@penguintechs.org> <200811230552.02221.zippel@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Andrew Morton" , linux-fsdevel@vger.kernel.org To: "Roman Zippel" Return-path: Received: from rv-out-0506.google.com ([209.85.198.224]:21467 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbYKYXp4 (ORCPT ); Tue, 25 Nov 2008 18:45:56 -0500 Received: by rv-out-0506.google.com with SMTP id k40so184131rvb.1 for ; Tue, 25 Nov 2008 15:45:56 -0800 (PST) In-Reply-To: <200811230552.02221.zippel@linux-m68k.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Nov 22, 2008 at 8:52 PM, Roman Zippel wrote: > I'm curious how common it is to have the journal bit set but no journal block, > I haven't seen this case so far. It's so uncommon that the technote for HFS+ doesn't mention it. However, I did find [1], and it's (c) by Apple. Look at the comment at [2] to see what tipped me off. > IMO more useful would be to read the journal block and check if there is > anything that needs to be replayed. > If you're interested in a second step you could replay the journal, it's not > that difficult to do, it's pretty much just copying blocks around. I am actually looking into doing the journal replaying, but i haven't gotten around to it yet. [1]http://fxr.watson.org/fxr/source/bsd/hfs/hfs_format.h?v=xnu-1228#L626 [2]http://fxr.watson.org/fxr/source/bsd/hfs/hfs_format.h?v=xnu-1228#L633 wt