linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bernd Schubert <bernd.schubert@fastmail.fm>
To: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Miklos Szeredi <miklos@szeredi.hu>
Cc: Joanne Koong <joannelkoong@gmail.com>,
	Josef Bacik <josef@toxicpanda.com>
Subject: fuse-io-uring: We need to keep the tag/index
Date: Wed, 2 Oct 2024 23:54:00 +0200	[thread overview]
Message-ID: <e3a4e7a8-a40f-495f-9c7c-1f296c306a35@fastmail.fm> (raw)

Hi Miklos,

in the discussion we had you asked to avoid an entry tag/index,
in the mean time I don't think we can. 
In fuse_uring_cmd(), i.e. the function that gets 
'struct io_uring_cmd *cmd' we need identify the corresponding fuse
data structure ('struct fuse_ring_ent'). Basically same as in
as in do_write(), which calls request_find() and does a list search.
With a large queue size that would be an issue (and even for smaller
queue sizes not beautiful, imho).

I'm now rewriting code to create an index in
FUSE_URING_REQ_FETCH and return that later on with the request
to userspace. That needs to do realloc the array as we do know the
exact queue size anymore.


Please let me know if you should have another suggestion.


Thanks,
Bernd


PS: In code review Joanne didn't like 'tag' too much (I took that 
over from ublk). I personally find index/idx too generic - any naming
suggestion is appreciated :)


             reply	other threads:[~2024-10-02 21:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02 21:54 Bernd Schubert [this message]
2024-10-03  9:50 ` fuse-io-uring: We need to keep the tag/index Miklos Szeredi
2024-10-03 10:10   ` Bernd Schubert
2024-10-03 12:02     ` Miklos Szeredi
2024-10-03 13:19       ` Bernd Schubert
2024-10-03 13:56         ` Bernd Schubert
2024-10-03 14:02           ` Miklos Szeredi
2024-10-03 14:04             ` Miklos Szeredi
2024-10-03 14:09               ` Bernd Schubert
2024-10-03 14:26                 ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3a4e7a8-a40f-495f-9c7c-1f296c306a35@fastmail.fm \
    --to=bernd.schubert@fastmail.fm \
    --cc=joannelkoong@gmail.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).