From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F85632E74E for ; Tue, 21 Oct 2025 11:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761047699; cv=none; b=ofy6WIIfV4xLoEoYvdVvljxWClVAzhlbSg5YtWhHTY1VLPcyItknQE05Egx4H7BP5KxhNelCmZyOpgrOFbUo4aYkOGb/OqARNLRBs9boqSYtqPUvgEbRJm0xvA6ih7vomQaLb9wwcDEmJgRdCY5yV5kjqPKVxhEIFERzmCX4eUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761047699; c=relaxed/simple; bh=i0j8FgwGPeON0SRekmlOd+y+TUDvqNz3NMsXik0Po60=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BLL7TBQ5XAmUSvvPeK4bfyo2M+nga9zU0d4Ei+4IosnxzilsZeTTn1PG1zBt7Zw8WcPBPBcACNZbPMXfSUWzqvLxQkodX8oFQdTgZm1cPi+aZ2CmRh1Mi3rR41JZ5WKrgO5x8zIHpFpMxdHo71VM3l3eS83vncjLz0s3wq9SkC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PS9SWLN0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PS9SWLN0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761047696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UjhTzDfDRfRTb0ujoYWqdsfQUJ32BJBRRtMqD14uvto=; b=PS9SWLN08LNen3PGvbyT8PmGH1y2BA9/ieW6go5VA6FNOVXsnPwfgEjaNHuQKFIK++1+yU UkbntCDFKcovJS6NwwXyoDECm+DuKO6wxFhB4LS3KunWl4ANcOOgU9qy5R8ObVhSCymGsA kAv8cKEUmvhIFKtQSO8dUPmpXkx8BYU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-EPlRnzZnNQKkSIOjLXhiUg-1; Tue, 21 Oct 2025 07:54:55 -0400 X-MC-Unique: EPlRnzZnNQKkSIOjLXhiUg-1 X-Mimecast-MFC-AGG-ID: EPlRnzZnNQKkSIOjLXhiUg_1761047694 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-427015f63faso2832825f8f.0 for ; Tue, 21 Oct 2025 04:54:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761047694; x=1761652494; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UjhTzDfDRfRTb0ujoYWqdsfQUJ32BJBRRtMqD14uvto=; b=LdNNRwvSNobYCcOxsGeCB3kSzlHfoRf5vwLso1tXb4RherRkenuir/JeokPgtOebNn vYXVdqFxybDCEH2/7fQsu33wOzKR7wOHIlo2UCWXjJ8rZYYWPVFcKs8FCN0GT+qWp52V sCpGpJQtRIswshedgCWlk36nq1f/jtZ5erfZdUKTN8JZ9YEqIWv8kjtekczyCmzFvi/5 IlfYIiQtbSq5e6GZTA6Osx6LwGgC5SzyzlVMRmblKUpx7LBXvjqokhHqB8ckqZL/BOs6 yaOgLjEXR+RyLhk5bUbt+I17bbyM5WYbOQQ56kxr6prj/LWcX0jbmxsPeRjU7j0Sf+d9 SlhQ== X-Forwarded-Encrypted: i=1; AJvYcCWztUr+LLPKuS2Vma+gwmwcGcDOP6sBzPwmUtoAkT5IJLNY3NVI0syUd8nEnJeSgE/6LFzC2102KF3IiZyu@vger.kernel.org X-Gm-Message-State: AOJu0YxGxFR1y428tszHpVYNNZxzgdQag7za7YqHO2kDH/C8qZR4hG7C DF4qYnjn9FsBDxbVubdc/mC3oogur7N2eSPXSPy32EQUBcPG7UiVSZ2uDahGUp/vQsZi3MyoJFH eporUtFLe9tBajWkgXjdtUD0Zmis5kYQYDdnhK2iK3Cx2FPepMYGYl2IexRhnakAZIsU= X-Gm-Gg: ASbGncsmV3YEUxwNgpmbjXwb74HZsusPOHrGFXlrfJWWDrA/PP1lSgoaHXhQwt5L5AJ XOrjFpBJAoJwVrCQlyE7tmF0dM56J36JojWZbV8Fwh8TJcRuTua3F4CsjCx7c7lY+lFXwL9f//l lIvKF9Hxpzk4FQJM4qU1uMT+tzDbDLN2spJnhnosfjU2/XFodRWSZ7RLXIETJCfWJFE9K7CiSsK I6w5lv2Vzg2/3pw/X2PCEhB4ioUrHCadlB5iNmTBIOmWUSemHVoj7MHrMdXro5edj9hMj19LmVG SbmtONUNyA2bjhBSw1LkCwGyMFo+P1PUh1t0E4rxuVtCoKSOoghryaZz3Sy9br8Mzl7xLHfcFN/ wvCDFjywPQZR4hHSvXzXMaU/pXdvSEdzlXEtSrWrcvO7sMgCsUmop+PvU3/lyOCaiYa8B3TtHKO BSSll4pNGr1F+4IBZ/UuR/QEDUgM8= X-Received: by 2002:a05:6000:3105:b0:427:64c:daaa with SMTP id ffacd0b85a97d-427064cdaecmr11329356f8f.44.1761047694098; Tue, 21 Oct 2025 04:54:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4hoS405o7SL+OX0J5tYiis8Ib15FCEt5fy5LSf9ht7t7QJikfAXYAkg1xAnP6qrMgvDH/9g== X-Received: by 2002:a05:6000:3105:b0:427:64c:daaa with SMTP id ffacd0b85a97d-427064cdaecmr11329329f8f.44.1761047693656; Tue, 21 Oct 2025 04:54:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3? (p200300d82f4e3200c99da38b3f3ad4b3.dip0.t-ipconnect.de. [2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5a0f88sm19307889f8f.7.2025.10.21.04.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 04:54:53 -0700 (PDT) Message-ID: Date: Tue, 21 Oct 2025 13:54:51 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/truncate: Unmap large folio on split failure To: Kiryl Shutsemau Cc: Andrew Morton , Hugh Dickins , Matthew Wilcox , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Johannes Weiner , Shakeel Butt , Baolin Wang , "Darrick J. Wong" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251021063509.1101728-1-kirill@shutemov.name> <20251021063509.1101728-2-kirill@shutemov.name> <37ceab54-c4b2-449e-aa46-ffaefe525737@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21.10.25 13:31, Kiryl Shutsemau wrote: > On Tue, Oct 21, 2025 at 11:47:11AM +0200, David Hildenbrand wrote: >> On 21.10.25 11:44, David Hildenbrand wrote: >>> On 21.10.25 08:35, Kiryl Shutsemau wrote: >>>> From: Kiryl Shutsemau >>>> >>>> Accesses within VMA, but beyond i_size rounded up to PAGE_SIZE are >>>> supposed to generate SIGBUS. >>>> >>>> This behavior might not be respected on truncation. >>>> >>>> During truncation, the kernel splits a large folio in order to reclaim >>>> memory. As a side effect, it unmaps the folio and destroys PMD mappings >>>> of the folio. The folio will be refaulted as PTEs and SIGBUS semantics >>>> are preserved. >>>> >>>> However, if the split fails, PMD mappings are preserved and the user >>>> will not receive SIGBUS on any accesses within the PMD. >>>> >>>> Unmap the folio on split failure. It will lead to refault as PTEs and >>>> preserve SIGBUS semantics. >>> >>> Was the discussion on the old patch set already done? I can spot that >>> you send this series 20min after asking Dave > > Based on feedback from Dave and Christoph on this patchset as well as > comments form Matthew and Darrick ont the report thread I see that my > idea to relax SIGBUS semantics for large folios will not fly :/ Then I was probably misreading the last email from you, likely the question you raised was independent of the progress of this series and more of general nature I assume. > > But if you want to weigh in... No, I think this makes sense. It's a regression that should be fixed. > >> Also, please send a proper patch series including cover letter that >> describes the changes since the last RFC. > > There is no change besides Signed-off-bys. Then point that out, please. It's common practice in MM to send cover letters for each new revision. For example, Andrew will usually incorporate the cover letter into patch #1 when merging. -- Cheers David / dhildenb