From: Bart Van Assche <bvanassche@acm.org>
To: Peter Zijlstra <peterz@infradead.org>,
Dave Chinner <david@fromorbit.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Ingo Molnar <mingo@redhat.com>, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH RFC] kernel/locking, fs/direct-io: Introduce and use down_write_nolockdep()
Date: Sun, 28 Oct 2018 13:45:27 -0700 [thread overview]
Message-ID: <e47c7cb1-2bb5-e6ad-8692-d36b5f8ed6bd@acm.org> (raw)
In-Reply-To: <20181028175840.GA744@hirez.programming.kicks-ass.net>
On 10/28/18 10:58 AM, Peter Zijlstra wrote:
> On Sat, Oct 27, 2018 at 04:37:45PM +1100, Dave Chinner wrote:
>> As an API, however, this needs to be consistent with
>> down_read_non_owner()/up_read_non_owner() which are for exactly this
>> same issue issue (different acquire/release contexts) on the read
>> side of the rwsem. Indeed, it can probably use the same
>> infrastructure...
>
> Also, from a quick look, this has been broken for donkeys years,
> right?
Hi Peter,
If you are referring to the direct I/O code: the lockdep complaint shown
in my patch description is new. I think the following commit from two
months ago (which seems fine to me) made that lockdep complaint appear:
87915adc3f0a ("workqueue: re-add lockdep dependencies for flushing").
Bart.
prev parent reply other threads:[~2018-10-29 5:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 16:49 [PATCH RFC] kernel/locking, fs/direct-io: Introduce and use down_write_nolockdep() Bart Van Assche
2018-10-26 17:43 ` Matthew Wilcox
2018-10-26 18:11 ` Bart Van Assche
2018-10-26 18:38 ` Matthew Wilcox
2018-10-26 19:12 ` Bart Van Assche
2018-10-27 5:37 ` Dave Chinner
2018-10-28 17:58 ` Peter Zijlstra
2018-10-28 20:34 ` Christoph Hellwig
2018-10-28 20:45 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e47c7cb1-2bb5-e6ad-8692-d36b5f8ed6bd@acm.org \
--to=bvanassche@acm.org \
--cc=david@fromorbit.com \
--cc=johannes.berg@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).