From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06DDC7EE26 for ; Fri, 5 May 2023 14:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232090AbjEEOME (ORCPT ); Fri, 5 May 2023 10:12:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232366AbjEEOMB (ORCPT ); Fri, 5 May 2023 10:12:01 -0400 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C576CAD34 for ; Fri, 5 May 2023 07:11:55 -0700 (PDT) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-55a202d44e6so2122217b3.0 for ; Fri, 05 May 2023 07:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1683295915; x=1685887915; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lYPB3stPQmWSExnYMshDYbYhsfa2W+OlQjJxEpndWnM=; b=qq9k4CHhMcGwgjJP+XM1athe5OHlLq0D26Ch4Y7iLMqhrY6QdPYKg1AtxVumk1ffcg RpfIYS8xAG6L5x7Tb30DAUHqZ9JIwJtrklJT5Xx8ObnVzeY9gSzPiW/toPtuXaGux6eQ /ZT2nMq+AtMMIpZmEcvQLLIsHsiY7R8AjFY8UNrKUp7ru2uqEl4XNnPRIw/lYncqAdXh 86+ECEijeVraFzpt3bV587DuKIeREe4VKB6ECv4H52ADB5Q6EAVlhlJ7+Yx1b7HcS+9y 6+4ve2FZ3mHqxFYatqkm+vN4DsB5xLgcdPhoqy7i9rNsyYc997kMMoXNsZl/kNyeyH5F mtYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683295915; x=1685887915; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lYPB3stPQmWSExnYMshDYbYhsfa2W+OlQjJxEpndWnM=; b=b2sVjYP/lH92Vle2Yt8Q/x/QzF7DsTWY4B0joDDJ02tvj7tWlMSTbjcuNPE32HCZHX qB/vfb6Qz+oNa+KKAAjJn7Dc6seGEHkOcLCT8kzIvSvWcN4tz7FRJiMWgDEtZSN9hrR4 jQvl2YZpAVFgVbRGDb93G9UJ1ju+jCYt840QZw03aLp9m8baFJxjdXAZc9RC+irBophB 1Jqxn8ZniX2GjVLUmt/j30DxCFJeTl2zkPZCXB3nP/ULdeu44qOcu9+Wy564CQu2h5kj L8w/scm/fYCtoQRwJ/b9wv5wszZB/0dvi5NL0oFlXwymXBm8bzId0It6cZGPA35+1+Xq jXgg== X-Gm-Message-State: AC+VfDzu1MvmQa9MEe4iRTmqTGCmSV92uFl/dGf2lSTrXez1IV4uy4fi 3cyZAT6qavoqcU4dp5gs46gT1g== X-Google-Smtp-Source: ACHHUZ6qoOI/+PGpkkPitfDFrwnR+RSgPJAmgOvbSJFeS3wnUhPPJunQJdt8ejTtUoT1u+x3g04+yQ== X-Received: by 2002:a81:5d6:0:b0:55a:9e2f:933d with SMTP id 205-20020a8105d6000000b0055a9e2f933dmr1748012ywf.1.1683295914848; Fri, 05 May 2023 07:11:54 -0700 (PDT) Received: from [172.20.2.186] ([12.153.103.3]) by smtp.gmail.com with ESMTPSA id x8-20020a814a08000000b0054f56baf3f2sm264788ywa.122.2023.05.05.07.11.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 07:11:53 -0700 (PDT) Message-ID: Date: Fri, 5 May 2023 08:11:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 00/20] bio: check return values of bio_add_page Content-Language: en-US To: Johannes Thumshirn Cc: "agruenba@redhat.com" , "cluster-devel@redhat.com" , Damien Le Moal , "dm-devel@redhat.com" , "hare@suse.de" , "hch@lst.de" , "jfs-discussion@lists.sourceforge.net" , "kch@nvidia.com" , "linux-block@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-raid@vger.kernel.org" , "ming.lei@redhat.com" , "rpeterso@redhat.com" , "shaggy@kernel.org" , "snitzer@kernel.org" , "song@kernel.org" , "willy@infradead.org" References: <20230502101934.24901-1-johannes.thumshirn@wdc.com> <1ac1fc5e-3c32-9d62-65bf-5ccbb82c37cc@wdc.com> From: Jens Axboe In-Reply-To: <1ac1fc5e-3c32-9d62-65bf-5ccbb82c37cc@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 5/5/23 2:09?AM, Johannes Thumshirn wrote: > On 02.05.23 12:20, Johannes Thumshirn wrote: >> We have two functions for adding a page to a bio, __bio_add_page() which is >> used to add a single page to a freshly created bio and bio_add_page() which is >> used to add a page to an existing bio. >> >> While __bio_add_page() is expected to succeed, bio_add_page() can fail. >> >> This series converts the callers of bio_add_page() which can easily use >> __bio_add_page() to using it and checks the return of bio_add_page() for >> callers that don't work on a freshly created bio. >> >> Lastly it marks bio_add_page() as __must_check so we don't have to go again >> and audit all callers. >> >> Changes to v4: >> - Rebased onto latest Linus' master >> - Dropped already merged patches >> - Added Sergey's Reviewed-by >> >> Changes to v3: >> - Added __bio_add_folio and use it in iomap (Willy) >> - Mark bio_add_folio must check (Willy) >> - s/GFS/GFS2/ (Andreas) >> >> Changes to v2: >> - Removed 'wont fail' comments pointed out by Song >> >> Changes to v1: >> - Removed pointless comment pointed out by Willy >> - Changed commit messages pointed out by Damien >> - Colledted Damien's Reviews and Acks > > Jens any comments on this? I'll take a look post -rc1. -- Jens Axboe