From: Julia Lawall <julia.lawall@inria.fr>
To: Joel Granados <joel.granados@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
kernel-janitors@vger.kernel.org, Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 09/35] sysctl: Reorganize kerneldoc parameter names
Date: Tue, 22 Oct 2024 13:13:25 -0700 (PDT) [thread overview]
Message-ID: <e6f7d5e-6f7e-ed6-a54a-2a5fd87b3d7f@inria.fr> (raw)
In-Reply-To: <nnbmui2ix23wjmfvxo2t3zd3tgymk77h765kyoc3pxu6wkhqxx@6qis4yyszkec>
On Tue, 22 Oct 2024, Joel Granados wrote:
> On Mon, Sep 30, 2024 at 01:20:55PM +0200, Julia Lawall wrote:
> > Reorganize kerneldoc parameter names to match the parameter
> > order in the function header.
> >
> > Problems identified using Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> >
> > ---
> > kernel/sysctl.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > index 79e6cb1d5c48..5c9202cb8f59 100644
> > --- a/kernel/sysctl.c
> > +++ b/kernel/sysctl.c
> > @@ -1305,7 +1305,6 @@ int proc_dointvec_userhz_jiffies(const struct ctl_table *table, int write,
> > * @write: %TRUE if this is a write to the sysctl file
> > * @buffer: the user buffer
> > * @lenp: the size of the user buffer
> > - * @ppos: file position
> > * @ppos: the current position in the file
> > *
> > * Reads/writes up to table->maxlen/sizeof(unsigned int) integer
> >
> This looks good to me. Is it going to go into main line together with
> the other 35 or should I take this one through sysctl subsystem?
Please take it,
julia
>
> Best
>
> Signed-off-by: Joel Granados <joel.granados@kernel.com>
>
> --
>
> Joel Granados
>
next prev parent reply other threads:[~2024-10-22 20:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 11:20 [PATCH 00/35] Reorganize kerneldoc parameter names Julia Lawall
2024-09-30 11:20 ` [PATCH 08/35] fs: " Julia Lawall
2024-09-30 12:09 ` (subset) " Christian Brauner
2024-09-30 12:25 ` Jan Kara
2024-09-30 11:20 ` [PATCH 09/35] sysctl: " Julia Lawall
2024-10-22 19:31 ` Joel Granados
2024-10-22 20:13 ` Julia Lawall [this message]
2024-10-23 13:38 ` Joel Granados
2024-10-06 1:55 ` (subset) [PATCH 00/35] " Bjorn Andersson
2024-11-17 12:09 ` Michael Ellerman
2024-12-20 17:27 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6f7d5e-6f7e-ed6-a54a-2a5fd87b3d7f@inria.fr \
--to=julia.lawall@inria.fr \
--cc=joel.granados@kernel.org \
--cc=kees@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).