From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82893C04A6A for ; Mon, 7 Aug 2023 15:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230473AbjHGPhi (ORCPT ); Mon, 7 Aug 2023 11:37:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230469AbjHGPhd (ORCPT ); Mon, 7 Aug 2023 11:37:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DD42C4 for ; Mon, 7 Aug 2023 08:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691422609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wCM0LSVABzEid+9ZFB8RVu58baVBQ5wmkVT334cAYKs=; b=dlHOSv6650uKMK7y6IFub5qerDl7w/6oHXuqCiC2rXK7mXr0JaPfo+E0c0YD8ioIr4HVmD Wl46VYkPR4tWQsXn+AIpaqy3XaIATCi2jUq7G4GuJ6ctQVWbQmfcPq7ObIiTPefN+sRH7z AfSheYF0HQNqc6MtYoAU+1yfNmHdYk0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-qIpDTy_dMSCd9wBn_3QTbw-1; Mon, 07 Aug 2023 11:36:48 -0400 X-MC-Unique: qIpDTy_dMSCd9wBn_3QTbw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3172a94b274so2521665f8f.0 for ; Mon, 07 Aug 2023 08:36:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691422607; x=1692027407; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wCM0LSVABzEid+9ZFB8RVu58baVBQ5wmkVT334cAYKs=; b=DpgwyjnH/2bZXH7nFIUTZjov06izoEzV5L3GMVx/uOLJRZThE/1cXCwcY43vsZjeDH Ri2YsBX1meTXX9Sf7s0a6kqckxV0yl1NoXYjhGSXHXf4i9SEnlhTYSba+xUWCgQ7WJQm yCgBMciEeFNZ+ZXeWZeNzrbWdEwWToq2z2QtXjwlm0fv3YZdPRg//dsoU2Tt0Qev6Xt4 ZOJOYuHXK0m5JGD8nV4sdDlP3YUK33PwcqfPafFgcqj/AnQZn5w2v8hfY7hivzKZMwYK 9DdL7TjxdfRSB7U4lLbZu5t1hogcwM2KvscXxZ9zl+veC7tcyVEBD2YLnR3kRBvJZibR ATJQ== X-Gm-Message-State: AOJu0YwFg0Cy54NLcCKBTfY1SgyvpfHHbMXKY6AnepMk4K2ihQQTovjS hHGEw7z28jAz0q9TxpByUwcl7h4P1Ph0UUwsof/LNQOBY+C8GJU3ddoLdmY94GO7CvytxgaMyTw JQQHmNmvXw9LV6/Y/cin6BY5Ktg== X-Received: by 2002:a5d:4085:0:b0:315:96ca:dcab with SMTP id o5-20020a5d4085000000b0031596cadcabmr7337371wrp.35.1691422607007; Mon, 07 Aug 2023 08:36:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFazJ0hQvyp0w7nVsyclbNvRXnBSHlJEwsegobzfYo7VP5sfkvDEV8yiWkWqkqGh7ZbhT/yBw== X-Received: by 2002:a5d:4085:0:b0:315:96ca:dcab with SMTP id o5-20020a5d4085000000b0031596cadcabmr7337347wrp.35.1691422606590; Mon, 07 Aug 2023 08:36:46 -0700 (PDT) Received: from [192.168.3.108] (p4ff234da.dip0.t-ipconnect.de. [79.242.52.218]) by smtp.gmail.com with ESMTPSA id s1-20020adff801000000b00314417f5272sm10811517wrp.64.2023.08.07.08.36.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 08:36:46 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 17:36:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 7/7] selftest/mm: ksm_functional_tests: Add PROT_NONE test Content-Language: en-US To: linux-kernel@vger.kernel.org, Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini References: <20230803143208.383663-1-david@redhat.com> <20230803143208.383663-8-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230803143208.383663-8-david@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 03.08.23 16:32, David Hildenbrand wrote: > Let's test whether merging and unmerging in PROT_NONE areas works as > expected. > > Pass a page protection to mmap_and_merge_range(), which will trigger > an mprotect() after writing to the pages, but before enabling merging. > > Make sure that unsharing works as expected, by performing a ptrace write > (using /proc/self/mem) and by setting MADV_UNMERGEABLE. > > Note that this implicitly tests that ptrace writes in an inaccessible > (PROT_NONE) mapping work as expected. > > Signed-off-by: David Hildenbrand > --- Andrew, can you squash the following? From c2be7c02cb96b9189a52a5937821600ef4e259bd Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Mon, 7 Aug 2023 17:33:54 +0200 Subject: [PATCH] Fixup: selftest/mm: ksm_functional_tests: Add PROT_NONE test As noted by Peter, we should be using sizeof(i) in test_prot_none(). Signed-off-by: David Hildenbrand --- tools/testing/selftests/mm/ksm_functional_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c index 8fa4889ab4f3..901e950f9138 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -516,7 +516,7 @@ static void test_prot_none(void) /* Store a unique value in each page on one half using ptrace */ for (i = 0; i < size / 2; i += pagesize) { lseek(mem_fd, (uintptr_t) map + i, SEEK_SET); - if (write(mem_fd, &i, sizeof(size)) != sizeof(size)) { + if (write(mem_fd, &i, sizeof(i)) != sizeof(i)) { ksft_test_result_fail("ptrace write failed\n"); goto unmap; } -- 2.41.0 -- Cheers, David / dhildenb