From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Christophe Vu-Brugier'" <cvubrugier@fastmail.fm>,
<linux-fsdevel@vger.kernel.org>
Cc: "'Namjae Jeon'" <linkinjeon@kernel.org>,
"'Matthew Wilcox'" <willy@infradead.org>,
"'Christophe Vu-Brugier'" <christophe.vu-brugier@seagate.com>,
<sj1557.seo@samsung.com>
Subject: RE: [PATCH v2] exfat: fix i_blocks for files truncated over 4 GiB
Date: Mon, 22 Nov 2021 11:10:11 +0900 [thread overview]
Message-ID: <e9d301d7df46$1441f290$3cc5d7b0$@samsung.com> (raw)
In-Reply-To: <20211119173734.2545-1-cvubrugier@fastmail.fm>
> From: Christophe Vu-Brugier <christophe.vu-brugier@seagate.com>
>
> In exfat_truncate(), the computation of inode->i_blocks is wrong if the
> file is larger than 4 GiB because a 32-bit variable is used as a mask.
> This is fixed and simplified by using round_up().
>
> Also fix the same buggy computation in exfat_read_root() and another
> (correct) one in exfat_fill_inode(). The latter was fixed another way last
> month but can be simplified by using round_up() as well. See:
>
> commit 0c336d6e33f4 ("exfat: fix incorrect loading of i_blocks for
> large files")
>
> Signed-off-by: Christophe Vu-Brugier <christophe.vu-brugier@seagate.com>
> Suggested-by: Matthew Wilcox <willy@infradead.org>
Thanks for your patch!
Please update your patch again with below tags.
Fixes: 719c1e1829166 ("exfat: add super block operations")
Fixes: 98d917047e8b7 ("exfat: add file operations")
Cc: stable@vger.kernel.org # v5.7+
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
next prev parent reply other threads:[~2021-11-22 2:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 21:28 [PATCH 0/1] exfat: fix i_blocks for files truncated over 4 GiB Christophe Vu-Brugier
2021-11-18 21:28 ` [PATCH 1/1] " Christophe Vu-Brugier
2021-11-18 21:50 ` Matthew Wilcox
2021-11-18 22:43 ` Christophe Vu-Brugier
2021-11-19 17:37 ` [PATCH v2] " Christophe Vu-Brugier
2021-11-22 2:10 ` Sungjong Seo [this message]
2021-11-22 2:33 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e9d301d7df46$1441f290$3cc5d7b0$@samsung.com' \
--to=sj1557.seo@samsung.com \
--cc=christophe.vu-brugier@seagate.com \
--cc=cvubrugier@fastmail.fm \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).