From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Duane Griffin" <duaneg@dghda.com>
Subject: Re: [patch] rd: support XIP
Date: Tue, 4 Dec 2007 12:06:23 +0000
Message-ID: <e9e943910712040406g17ae4293u72ddb63b55549e63@mail.gmail.com>
References: <20071204042628.GA26636@wotan.suse.de>
	 <200712041054.51599.borntraeger@de.ibm.com>
	 <20071204101009.GB9618@wotan.suse.de>
	 <20071204112100.GA20420@wotan.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Andrew Morton" <akpm@linux-foundation.org>, rob@landley.net,
	"Jens Axboe" <axboe@kernel.dk>
To: "Nick Piggin" <npiggin@suse.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from py-out-1112.google.com ([64.233.166.180]:40791 "EHLO
	py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752585AbXLDMG0 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 4 Dec 2007 07:06:26 -0500
Received: by py-out-1112.google.com with SMTP id u77so7162873pyb
        for <linux-fsdevel@vger.kernel.org>; Tue, 04 Dec 2007 04:06:25 -0800 (PST)
In-Reply-To: <20071204112100.GA20420@wotan.suse.de>
Content-Disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 04/12/2007, Nick Piggin <npiggin@suse.de> wrote:
> +       gfp_flags = GFP_NOIO | __GFP_ZERO;
> +#ifndef CONFIG_BLK_DEV_XIP
> +       gfp_flags |= __GFP_HIGHMEM;
> +#endif
>         page = alloc_page(GFP_NOIO | __GFP_HIGHMEM | __GFP_ZERO);

I think that should be alloc_page(gfp_flags), no?

Cheers,
Duane.

-- 
"I never could learn to drink that blood and call it wine" - Bob Dylan