From: "Manish Katiyar" <mkatiyar@gmail.com>
To: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] ext2 : Remove redundant condition in ext2_free_blocks()
Date: Sun, 1 Jun 2008 00:26:33 +0530 [thread overview]
Message-ID: <ea11fea30805311156o3715d3f9ibd4ea8b44a8f3223@mail.gmail.com> (raw)
For two unsigned values the check "block+count < block" is always
false. Thus the below patch removes that condition.
=============================================================
Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
--- a/fs/ext2/balloc.c 2008-05-11 23:54:40.000000000 +0530
+++ b/fs/ext2/balloc.c 2008-06-01 00:03:44.000000000 +0530
@@ -499,7 +499,6 @@
unsigned freed = 0, group_freed;
if (block < le32_to_cpu(es->s_first_data_block) ||
- block + count < block ||
block + count > le32_to_cpu(es->s_blocks_count)) {
ext2_error (sb, "ext2_free_blocks",
"Freeing blocks not in datazone - "
=============================================================
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
next reply other threads:[~2008-05-31 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 18:56 Manish Katiyar [this message]
2008-06-03 12:33 ` [PATCH] ext2 : Remove redundant condition in ext2_free_blocks() Mark Asselstine
2008-06-03 13:28 ` Manish Katiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea11fea30805311156o3715d3f9ibd4ea8b44a8f3223@mail.gmail.com \
--to=mkatiyar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).