From: "Manish Katiyar" <mkatiyar@gmail.com>
To: "Al Viro" <viro@zeniv.linux.org.uk>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb()
Date: Sun, 1 Jun 2008 00:40:32 +0530 [thread overview]
Message-ID: <ea11fea30805311210o15de2373m71d91228356f9bfd@mail.gmail.com> (raw)
In-Reply-To: <20080531190527.GG28946@ZenIV.linux.org.uk>
On Sun, Jun 1, 2008 at 12:35 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Sun, Jun 01, 2008 at 12:26:41AM +0530, Manish Katiyar wrote:
>> For two unsigned values the check "block+count < block" is always
>> false. Thus the below patch removes that condition.
>
> Really? Always?
>
> unsigned block = 1;
> unsigned count = ~0U;
>
> What will be the value and type of block + count? What will be the
> value of block + count < block?
Oooops....my bad, but I doubt if we pass such values in ext* code anywhere.
>
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
next prev parent reply other threads:[~2008-05-31 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 18:56 [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb() Manish Katiyar
2008-05-31 19:05 ` Al Viro
2008-05-31 19:10 ` Manish Katiyar [this message]
2008-06-03 13:20 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea11fea30805311210o15de2373m71d91228356f9bfd@mail.gmail.com \
--to=mkatiyar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).