* [PATCH] ext2 : correct comments in fs/ext2/balloc.c
@ 2008-06-03 12:25 Manish Katiyar
0 siblings, 0 replies; 4+ messages in thread
From: Manish Katiyar @ 2008-06-03 12:25 UTC (permalink / raw)
To: linux-ext4, linux-fsdevel, kernel-janitors
Resending with Mark's comment incorporated.
This patch corrects the wrong function name mentioned in the comments
of ext2_free_blocks() function
==========================================================
Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
Reviewed-by: Mark Asselstine <mark.asselstine@windriver.com>
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 10bb02c..12a24c0 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -478,7 +478,7 @@ void ext2_discard_reservation(struct inode *inode)
}
/**
- * ext2_free_blocks_sb() -- Free given blocks and update quota and i_blocks
+ * ext2_free_blocks() -- Free given blocks and update quota and i_blocks
* @inode: inode
* @block: start physcial block to free
* @count: number of blocks to free
============================================================
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ext2 : correct comments in fs/ext2/balloc.c
@ 2008-05-31 18:15 Manish Katiyar
2008-06-03 12:16 ` Mark Asselstine
0 siblings, 1 reply; 4+ messages in thread
From: Manish Katiyar @ 2008-05-31 18:15 UTC (permalink / raw)
To: linux-fsdevel, linux-ext4, kernel-janitors
This patch corrects the wrong function name mentioned in the comments
of ext2_free_blocks() function
========================================================
Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
--- a/fs/ext2/balloc.c 2008-05-11 23:54:40.000000000 +0530
+++ b/fs/ext2/balloc.c 2008-05-31 23:44:20.000000000 +0530
@@ -478,7 +478,7 @@
}
/**
- * ext2_free_blocks_sb() -- Free given blocks and update quota and i_blocks
+ * ext2_free_blocks() -- Free given blocks and update quota and i_blocks
* @inode: inode
* @block: start physcial block to free
* @count: number of blocks to free
==========================================================
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext2 : correct comments in fs/ext2/balloc.c
2008-05-31 18:15 Manish Katiyar
@ 2008-06-03 12:16 ` Mark Asselstine
2008-06-03 12:19 ` Manish Katiyar
0 siblings, 1 reply; 4+ messages in thread
From: Mark Asselstine @ 2008-06-03 12:16 UTC (permalink / raw)
To: Manish Katiyar; +Cc: linux-fsdevel, linux-ext4, kernel-janitors
On Sat, May 31, 2008 at 2:15 PM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> This patch corrects the wrong function name mentioned in the comments
> of ext2_free_blocks() function
>
> ========================================================
>
> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
Reviewed-by: Mark Asselstine <mark.asselstine@windriver.com>
One comment, lose the timestamps they add no value.
>
> --- a/fs/ext2/balloc.c 2008-05-11 23:54:40.000000000 +0530
> +++ b/fs/ext2/balloc.c 2008-05-31 23:44:20.000000000 +0530
> @@ -478,7 +478,7 @@
> }
>
> /**
> - * ext2_free_blocks_sb() -- Free given blocks and update quota and i_blocks
> + * ext2_free_blocks() -- Free given blocks and update quota and i_blocks
> * @inode: inode
> * @block: start physcial block to free
> * @count: number of blocks to free
>
>
> ==========================================================
>
> --
> Thanks & Regards,
> ********************************************
> Manish Katiyar ( http://mkatiyar.googlepages.com )
> 3rd Floor, Fair Winds Block
> EGL Software Park
> Off Intermediate Ring Road
> Bangalore 560071, India
> ***********************************************
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext2 : correct comments in fs/ext2/balloc.c
2008-06-03 12:16 ` Mark Asselstine
@ 2008-06-03 12:19 ` Manish Katiyar
0 siblings, 0 replies; 4+ messages in thread
From: Manish Katiyar @ 2008-06-03 12:19 UTC (permalink / raw)
To: Mark Asselstine; +Cc: linux-fsdevel, linux-ext4, kernel-janitors
On Tue, Jun 3, 2008 at 5:46 PM, Mark Asselstine <asselsm@gmail.com> wrote:
> On Sat, May 31, 2008 at 2:15 PM, Manish Katiyar <mkatiyar@gmail.com> wrote:
>> This patch corrects the wrong function name mentioned in the comments
>> of ext2_free_blocks() function
>>
>> ========================================================
>>
>> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
> Reviewed-by: Mark Asselstine <mark.asselstine@windriver.com>
>
> One comment, lose the timestamps they add no value.
OK Mark,... Will resend the patch with timestamp removed.
Thanks -
Manish
>>
>> --- a/fs/ext2/balloc.c 2008-05-11 23:54:40.000000000 +0530
>> +++ b/fs/ext2/balloc.c 2008-05-31 23:44:20.000000000 +0530
>> @@ -478,7 +478,7 @@
>> }
>>
>> /**
>> - * ext2_free_blocks_sb() -- Free given blocks and update quota and i_blocks
>> + * ext2_free_blocks() -- Free given blocks and update quota and i_blocks
>> * @inode: inode
>> * @block: start physcial block to free
>> * @count: number of blocks to free
>>
>>
>> ==========================================================
>>
>> --
>> Thanks & Regards,
>> ********************************************
>> Manish Katiyar ( http://mkatiyar.googlepages.com )
>> 3rd Floor, Fair Winds Block
>> EGL Software Park
>> Off Intermediate Ring Road
>> Bangalore 560071, India
>> ***********************************************
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-06-03 12:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-03 12:25 [PATCH] ext2 : correct comments in fs/ext2/balloc.c Manish Katiyar
-- strict thread matches above, loose matches on Subject: below --
2008-05-31 18:15 Manish Katiyar
2008-06-03 12:16 ` Mark Asselstine
2008-06-03 12:19 ` Manish Katiyar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).