From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2221F33CEB0 for ; Tue, 26 Aug 2025 15:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756222887; cv=none; b=hnF2HmJFijd0kyjQK8DbU1GgLRIVtMFEqJs1wXUKnAY8tIacBbGrcgolLFE9wjD23yOmyjIjl0qtFb72W/Oz8AlGcCaFE/q19h90QoTDF+jrUsUgS5IAtWO0s3vOI9HQHZPmZeEz+2wdKMJji15VHLjjf2I67dIOP3pIDaAyeqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756222887; c=relaxed/simple; bh=BcsxwfXtk0iNo1/SL2s/ecZqZhvAJgKGVc1u5U8/F38=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QKXDUbCudTvrmAW/4cGK5MOUoQFqpnN/kS4kdufaMnLBhb8gcvDfFbxStsyVruM1GsvnSgHExf4J6RCViyiVCzr+6Ub/nPHM+9QxG1Kw9FLqCDlDRKTaU6AfE47cvbSS3dEE+FG4wZagdc/ibCxr6LJ5yIZzJ/pk4BStXl05d6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com; spf=none smtp.mailfrom=toxicpanda.com; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b=ATwT5TzG; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b="ATwT5TzG" Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e96c77b8dc1so1614848276.1 for ; Tue, 26 Aug 2025 08:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1756222884; x=1756827684; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=pj/q5LV/Zjj+RGaDytTI7HVb3/yBVl27+fEybeIP2II=; b=ATwT5TzGHoxrj7PHJUbtByIbeBESmWp6ty18jiEYudGN9FBVYPOqTdTOeEIY7YBhMI Rppdv+reft/PaddOUc2vqF66FppCm1CPyfvy1sQTNikiO2Qh7sB3tNfGqxJEK3OtbFcH oRaoVl2QtV6cfmLBwh2BBH0pWG2UmsD2YQx7GmhIEPcGxSQp8VeHsaUi44XoEf+wNa1u WjUOHyXIsLfggsqbewQ58u/GrhjICly1+nVh+BIGyIk+ry1i0hbHCkGr8LYFiZrrT+xP wgQiL4bmSOyWHTw1tmPcJZku8ay62pA6qadRvIs1P31XbhS5ltysvtAmXNcOwko7cLFX N8qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756222884; x=1756827684; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pj/q5LV/Zjj+RGaDytTI7HVb3/yBVl27+fEybeIP2II=; b=BPocP2merIcZso61PnzmRk0+blm65FACG7h07pb2YxSHrKG58LYP1aq1Rg2HVCFWlQ CH2HRz307Rdda8+zZmZBYrCPQMr6GL5lyZwRLMDWeyuee7MRkeYo/xypqQXfzKy+l2oc vMwzhXjKSGEKE1ImlrEm+DIb7+Pj6OiiUHTxTVCUA5WZqx5C56AOzE/ej/XbgaFFcybI LtXWgxbDft+SCtt/zLIMJSk3KEeMCtqRAn2kJ3KcCLI5WN/AtKvGKYSOaRmZ2EWXDPqx GtctoDYHEc//9hmoynaW0GmqxwziGcMfbgxe2SElng7OGdxYcCyuWOjI67zDCU5y1g+6 RHMw== X-Gm-Message-State: AOJu0YxE5edmjxjdwwYiWc3sQ2cRdYNwnIQ43us2T0Vp779Ig1RoLmwH ayJS7Az6WrEkKI7YZ7dhjIGAbhxp5OqPU3TRvprmAe6nf+PFDiizMqt7B9ZdqIcRzO66m+4iCPM EODvu X-Gm-Gg: ASbGnct9dXS/wUj1f+WFdOPE4q7evwF2fPKqti7XrQ0rcE446aHUUoI5DZjgt0plrNP kTyVY3A6yBf3uQ3E/o1/EykyV7GrwI9f326NRRg4XDkA/njVpUvmveNMbvbmMWbDZK5QQFtFb/m 8HQ0CpSD1tGReZV0QKtzWtdXa/X6M95Ml9k5bIIWR7lRzIyq6H4bkWvNVAjXr3rxg+GZ493agPM 2EaVa0rH6ErY+xE/9DwI7ldFAAX50QoF7gIZ1nJOGc44l1Pn6m2OOPQZY7O7UM81zWLZxW8yFVr OqhnJJ6yRstI15pdUsTKBX0AJan5MYNRdKZhmpSafx+3dhDYGQMqUOyXfSxoUmvUU/hzGF2xw6R R74lfyMlMhc5thElAPTWFRM/nohsJWB/BdT6xhAMTGE3zLuFd4iOl4qcA6Qs= X-Google-Smtp-Source: AGHT+IFo3Ri8M1iGHczh+0kLy567c+XsPWYnjC+DbxsArk1jOqV22kRgMeMJMzsFpnNj7TQiFIR5Rg== X-Received: by 2002:a05:6902:120e:b0:e96:c67d:c61c with SMTP id 3f1490d57ef6-e96c67dcbafmr6156328276.8.1756222883548; Tue, 26 Aug 2025 08:41:23 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e96d661d1basm1058955276.13.2025.08.26.08.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 08:41:22 -0700 (PDT) From: Josef Bacik To: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, kernel-team@fb.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, brauner@kernel.org, viro@ZenIV.linux.org.uk, amir73il@gmail.com Subject: [PATCH v2 24/54] fs: use inode_tryget in find_inode* Date: Tue, 26 Aug 2025 11:39:24 -0400 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Now that we never drop the i_count to 0 for valid objects, rework the logic in the find_inode* helpers to use inode_tryget() to see if they have a live inode. If this fails we can wait for the inode to be freed as we know it's currently being evicted. Signed-off-by: Josef Bacik --- fs/inode.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 66402786cf8f..4ed2e8ff5334 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1093,6 +1093,7 @@ long prune_icache_sb(struct super_block *sb, struct shrink_control *sc) } static void __wait_on_freeing_inode(struct inode *inode, bool is_inode_hash_locked); + /* * Called with the inode lock held. */ @@ -1116,16 +1117,15 @@ static struct inode *find_inode(struct super_block *sb, if (!test(inode, data)) continue; spin_lock(&inode->i_lock); - if (inode->i_state & (I_FREEING|I_WILL_FREE)) { - __wait_on_freeing_inode(inode, is_inode_hash_locked); - goto repeat; - } if (unlikely(inode->i_state & I_CREATING)) { spin_unlock(&inode->i_lock); rcu_read_unlock(); return ERR_PTR(-ESTALE); } - __iget(inode); + if (!inode_tryget(inode)) { + __wait_on_freeing_inode(inode, is_inode_hash_locked); + goto repeat; + } inode_lru_list_del(inode); spin_unlock(&inode->i_lock); rcu_read_unlock(); @@ -1158,16 +1158,15 @@ static struct inode *find_inode_fast(struct super_block *sb, if (inode->i_sb != sb) continue; spin_lock(&inode->i_lock); - if (inode->i_state & (I_FREEING|I_WILL_FREE)) { - __wait_on_freeing_inode(inode, is_inode_hash_locked); - goto repeat; - } if (unlikely(inode->i_state & I_CREATING)) { spin_unlock(&inode->i_lock); rcu_read_unlock(); return ERR_PTR(-ESTALE); } - __iget(inode); + if (!inode_tryget(inode)) { + __wait_on_freeing_inode(inode, is_inode_hash_locked); + goto repeat; + } inode_lru_list_del(inode); spin_unlock(&inode->i_lock); rcu_read_unlock(); -- 2.49.0