From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185DFC433E2 for ; Fri, 17 Jul 2020 13:45:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F30862076A for ; Fri, 17 Jul 2020 13:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgGQNpQ (ORCPT ); Fri, 17 Jul 2020 09:45:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36014 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726221AbgGQNpP (ORCPT ); Fri, 17 Jul 2020 09:45:15 -0400 Received: from mail-wm1-f70.google.com ([209.85.128.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jwQfp-0007IF-0a for linux-fsdevel@vger.kernel.org; Fri, 17 Jul 2020 13:45:13 +0000 Received: by mail-wm1-f70.google.com with SMTP id g187so8974305wme.0 for ; Fri, 17 Jul 2020 06:45:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=FPUk81AWThrxk57hKh4xrD5ONlkucT+/ZYjjy9ESUtA=; b=Ji5oMnes2ZdyAacWZzWfSBX5jhIIkAxtnyuQIi/XHzuWgPA9k0349Fi5XNaZRtjfXf kWmEsJLv7ifaSMjmLZLdV5xuuzN+fVseOhUTo5dov3miFqOYlGMcHwY0S4xzy2OIN8rv 2Jb1+Nms/js+901dqrrIfwjPEV+8HbXpiWB1Lm3gB5PR3xjPNY+i01H3eezLIudPooLf QSk7zFSANljVHgxNdhjIkvW+YcKh9HXaJ1Dvq+IP0IhsZFBqCrzxm1ndRVb0a71SL/b/ 1KrULXO1s0actAsRlNkvAtM8ujjDd7NZZ+PkNwJM16LTv2WtVRpF0OYvK29rHTUJXIWJ NMRQ== X-Gm-Message-State: AOAM530ge8l0l8PSvmjYgafYP2TXb1Hj9GG24IbZhpmNt+3IWjjAZoSp e2m71qM3b0G/f2J5wjkWoRAL5diMYX1rKU5TypCw7bphyHSDOXcssF1b++plFx+1Q/BBlmrkGu7 RO+NufGe4ssoZX9XQxLiQ7+4GBt1WHtHP1Tt8UcCeT5M= X-Received: by 2002:adf:ee0b:: with SMTP id y11mr11000010wrn.360.1594993512709; Fri, 17 Jul 2020 06:45:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2odMU9lySgVrAbIQPtAQtFL0cCeE49RTAyB1sl30vP6fo+cSuO7guPPVM1BJpvATA1OlzUA== X-Received: by 2002:adf:ee0b:: with SMTP id y11mr10999993wrn.360.1594993512501; Fri, 17 Jul 2020 06:45:12 -0700 (PDT) Received: from [192.168.1.238] (dynamic-adsl-94-34-33-205.clienti.tiscali.it. [94.34.33.205]) by smtp.gmail.com with ESMTPSA id z63sm15370141wmb.2.2020.07.17.06.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 06:45:11 -0700 (PDT) Subject: Re: [PATCH 1/1] radix-tree: do not export radix_tree_preloads as GPL To: Sebastian Andrzej Siewior Cc: linux-fsdevel@vger.kernel.org, mingo@kernel.org, Seth Forshee References: <20200717101848.1869465-1-alberto.milone@canonical.com> <20200717104300.h7k7ho25hmslvtgy@linutronix.de> <20200717132147.nizfehgvzsdi2tfv@linutronix.de> From: Alberto Milone Autocrypt: addr=alberto.milone@canonical.com; keydata= mQINBE94HbYBEACugQ46qt+oEKdZ2AktngF8SoMWhotIn68YvoQYxm+0assnzQkxBw2tcY2E FzkqfXfyhKx3YR8msnnmuLS85PfXoWobXdnOZ+8r0QC8UlllMbElhL91L6HjIIJdKiwwamZP TddpJnEIfJwHfiONxSeAK3dgEkZ/inkbCA9z9WfvyTT4FDmdenyyOzJAbz1OvYFVUvn+9dcm t0SN1SPQsBcpYS5CdUsiA7qcYnwKYT62aIvpJ5K5sOyMtArJsO1+qL6Cv4Uoetsft1g2U3a8 Niif9hfbN0KkADt38OO/R6I5lJhelk2EW5XBFPRP9hKtQeWZL7Ge39LPmqplfvbP2xgEbNSg buwkwqoUtnh+QwRLyZKDLw40PhFH+LXq44lweSLL5Ir34scws36AQnJe3WNklQfQuoUmJGdR Uov7nv3ZyqFKTqmmCBqTBwL7m13JTt7EZxmkC4LU0HSUbglZInGIyG5iZKU1ukrMhQ5j1+mM Cy9z/WG/89TvsGqCnz/r0e5JMi9pNMh/UGT/qlblr5CKYneYVjEVHQJwOBGVqaqC3f2HYBa1 4W/5Kc60bRsIUGrBiCi6V3mFk8pWew8IRTxLRzoDz22t0sx2h1X19ZZCIhhYWknKkbEY4CfM NtukH/280FB/zUprVtG99MrtEdP4LzwhD+9+0ntMoPGDNFk9TQARAQABtC1BbGJlcnRvIE1p bG9uZSA8YWxiZXJ0by5taWxvbmVAY2Fub25pY2FsLmNvbT6JAjgEEwECACIFAk94HbYCGwMG CwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEOVyzPsrfKs1OIYQAJVdIWq8kA5x/s6Zv+Ib oO6u5a9RgJFcH65Gm/FM2KZFJiwKTocMimsW6/npG4y+0BVwSqYQ1Z1VsR/+1MTLPqf3qb2B rBy+7S6zN58s/qCyhq7Maq2KpZgxmz+nyCvmT7mMsTORthUYIdYGry7KXbnRpEy+3cJv5Icm BLHRgP79gYFZDSlTHbsn+Y1rTj/4jR03SL6oAxCmsFqrutudb/IJ6aYjXbrQdpe5am5Dcknt jewkPgxrYL5bqCUwKS2FvejkmjwoVvn3ZhnAQjXakj9wJbEj2zDQGxXm6SqnRgaccONPUZRu tPfGJZue2Tqzu5i6pOkmpxMz7s6SLP1kWIBoq2Y1WRATzgnE7NCON1JgVVVUQQfy/kB0JhZ5 IJYEL7Q5H74oEl6jzONqcmqGP129xoaSXU08HaR5gyq94XV6xqkaU5+IUa7IK89hBP78KszU 061RLFU6wDHwK2Dpb5Fr7xo7ee6byuqLuu5IoZDbu5COIyTl75cDItx+vmnx2nEkGnfSmlxf GZA1aKE8AoHubYvlP0gHWMivniSSfpBXR1iM7vzv2GRiL1GI66ltNHVv3p31lj4GaX0EZgoq eF2EX8CE9RXwRieh7CvJ4gpIbYHLc6yl9E4R+PwyPZ5+4GwLpJoZZOXPWLJl8u2izG0TMyJY 8v+tKdbtTFYHCW9EuQINBE94HbYBEADgobwHzyBSbA544+HHxga3deONHPWdJDrraOCcjMDJ hwjLhziE3pvTCUUpnevTYRY25WhBjmKjyg66/m/NiVXPcoAvfJaqx/01QMDetUK2gAU4Z+0h 5Pi5Za1tMGGUARd4egaKKnHH8ZbEyMUH3H+W1+8rrlKP3X0AnyQ+QTxxlxbk38yDvIludt07 r3HE0GCP8VwgcAVwYyMtmeBlUgeap0naUGIP3E/Il1eZGrml2fll4wKl3ZX+7MyCa78MWaOH evHwQX2zbf6EeHE9tL0yYmlSoX7iABp1OjXNh1eoneSb4FeATMH8gSMq/clvKBNuhZsPVrqd gXwrVbg4Wz8cf3rmH/Q/pQjwiL7ZnOVfEBz+06G9tvQw0GUx9TyPfgWEmGJws+y2aKT5ad48 zEXsH5QAp7xGRWBjQNWmjF0M/i8gqpTwCMYIP0KH6Pcaq24AmLboOVZyx0yFn0hYGxManZF9 DMW/brnuoeXVxYWt68eoEi0oaLE4yzQuQOY8H1lERKT5JgZhSRvws5Ca2SYKZiQc0xMboyt7 pKGaCUxRCAekWYy/w+70xV73MxwouR1hfpDol3fQ2H164Lxbbt/B9SqDrtBNFQOxmmEMjQ1w fSEoP541oOgU60mJ8sqBAEAgR+u+WpVOzxc7IbBGWd0Bc3fkM2Ek+Fn0svu2UDfIiQARAQAB iQIfBBgBAgAJBQJPeB22AhsMAAoJEOVyzPsrfKs1aJwQAJkcwjIaYrTG9K8HKfjJ2+Z/rC88 bO3Ex+RfFasCAzG8957TL0LtkpfIBolSrWxvF89Hp+PbG5WhAtviOcvvM29UFJnHrlGotcd6 NgNiHBhKOOJpihK0nUfmyCeK9dkLsvUTi+7gHsI4co13rODCzmQTV7UtJ0tSudvpQ+Wh6LXC 464HMUI9R5iDkaKY80blZa8hczc+Dv4k0OBr0ycwoApUm1jWtlg4J8g5YL3m4KJlHZpU9gQO TTbqCs/ss4O21oYvzwoE67QvEwUv+9HChaTfaWH4TMDEVBJ78dM2j0hunKFk17igqQCJEbMb kFTilz8gqyA817S13Uo5mXac1DdhDlSwOGJFCoqS/Y0SHJotmZCr9/192iUBG5Yp3tNAJ/lp ttsWR9X4zy0j1hV5hWRwCjw3igvDVlDs3o9LElaLiQvz1RVZp/YxMm3Wkt4zT0WwHhASdo3P 9MuLBaOkZgy5v9Nf9t1vOvvavbLSErGOVs92xt/8wLSxseyA6jaa2L+5IyC5gwG3T4xjRYRx zUqiY2XaPreH89Y1ArjmyiPJPlZ9yy1PC46rrq6fNpk0QuRnhkhz0Ep+iea0mcLH83Z9g4C0 s6Jf1qZYLdbk+E6/vbVMYOqYiSD/YA6e+gCbXC1gt5cdF/Q4eN5kwON6jqWJewKDFKeSHXPD NoFCMd+w Message-ID: Date: Fri, 17 Jul 2020 15:45:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200717132147.nizfehgvzsdi2tfv@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 17/07/2020 15:21, Sebastian Andrzej Siewior wrote: > On 2020-07-17 14:33:31 [+0200], Alberto Milone wrote: >> I checked and CONFIG_DEBUG_LOCK_ALLOC is not enabled in our kernels. > The access to that variable is optimized away if not for debug. I made > this: > | #include > | #include > | > | static int le_init(void) > | { > | idr_preload_end(); > | return 0; > | } > | module_init(le_init); > | > | static void le_exit(void) > | { > | } > | module_exit(le_exit); > | > | MODULE_DESCRIPTION("driver"); > | MODULE_LICENSE("prop"); > > and it produced a .ko. Here the "idr_preload_end()" was reduced to > "preempt_enable()" as intended. No access to > "&radix_tree_preloads.lock". > > Sebastian * Subscribing Seth