From: Vitaly Lipatov <lav@etersoft.ru>
To: Jeff Layton <jlayton@kernel.org>
Cc: wine-patches <wine-patches@winehq.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2] fs/fcntl: restore checking against COMPAT_LOFF_T_MAX for F_GETLK64
Date: Tue, 14 Nov 2017 19:48:00 +0300 [thread overview]
Message-ID: <eb619f2a1366f811ee4f626722437985@etersoft.ru> (raw)
In-Reply-To: <1510668403.4873.3.camel@kernel.org>
Jeff Layton писал 14.11.17 17:06:
...
>> break;
>> - err = fixup_compat_flock(&flock);
>> + err = fixup_compat_flock(&flock, COMPAT_OFF_T_MAX);
>
> I think you want COMPAT_LOFF_T_MAX here? In any case, I'm fine with the
> first version, and just renaming the function. I'll plan to push that
> one unless you have a reason that we should do it this way.
I would like send v3 with fix the typo you told me. As for me, it is
more clean than two functions.
Was I wrong with MessageId last time or it is ok to have a new thread
for every patch version?
--
С уважением,
Виталий Липатов,
Etersoft
next prev parent reply other threads:[~2017-11-14 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 1:30 [PATCH] fs/fcntl: restore checking against COMPAT_LOFF_T_MAX for F_GETLK64 Vitaly Lipatov
2017-11-14 11:29 ` Jeff Layton
2017-11-14 11:37 ` Vitaly Lipatov
2017-11-14 13:47 ` [PATCH v2] " Vitaly Lipatov
2017-11-14 14:06 ` Jeff Layton
2017-11-14 16:48 ` Vitaly Lipatov [this message]
2017-11-14 16:48 ` [PATCH v3] " Vitaly Lipatov
2017-11-14 17:17 ` J. Bruce Fields
2017-11-14 19:12 ` Jeff Layton
2017-11-14 19:25 ` Vitaly Lipatov
2017-11-14 20:19 ` Jeff Layton
2017-11-14 21:22 ` Vitaly Lipatov
2017-11-15 13:16 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb619f2a1366f811ee4f626722437985@etersoft.ru \
--to=lav@etersoft.ru \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wine-patches@winehq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).