From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.etersoft.ru ([91.232.225.46]:41921 "EHLO mail.etersoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754945AbdKNQsE (ORCPT ); Tue, 14 Nov 2017 11:48:04 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Date: Tue, 14 Nov 2017 19:48:00 +0300 From: Vitaly Lipatov To: Jeff Layton Cc: wine-patches , "J. Bruce Fields" , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v2] fs/fcntl: restore checking against COMPAT_LOFF_T_MAX for F_GETLK64 In-Reply-To: <1510668403.4873.3.camel@kernel.org> References: <20171114013009.26716-1-lav@etersoft.ru> <20171114134715.21649-1-lav@etersoft.ru> <1510668403.4873.3.camel@kernel.org> Message-ID: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jeff Layton =D0=BF=D0=B8=D1=81=D0=B0=D0=BB 14.11.17 17:06: =2E.. >> break; >> - err =3D fixup_compat_flock(&flock); >> + err =3D fixup_compat_flock(&flock, COMPAT_OFF_T_MAX); >=20 > I think you want COMPAT_LOFF_T_MAX here? In any case, I'm fine with the > first version, and just renaming the function. I'll plan to push that > one unless you have a reason that we should do it this way. I would like send v3 with fix the typo you told me. As for me, it is=20 more clean than two functions. Was I wrong with MessageId last time or it is ok to have a new thread=20 for every patch version? --=20 =D0=A1 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC, =D0=92=D0=B8=D1=82=D0=B0=D0=BB=D0=B8=D0=B9 =D0=9B=D0=B8=D0=BF=D0=B0=D1=82= =D0=BE=D0=B2, Etersoft