From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94814C74A5B for ; Wed, 29 Mar 2023 23:30:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231218AbjC2XaD (ORCPT ); Wed, 29 Mar 2023 19:30:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbjC2XaC (ORCPT ); Wed, 29 Mar 2023 19:30:02 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66DF41FFF for ; Wed, 29 Mar 2023 16:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132601; x=1711668601; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/Y/8nFwSzVjprTaZ9/Wyk96kEMW0qhqMfVVhpdupNbM=; b=h/Ah1jSekzdyvpgdfu2QaEVK/QoXRx+IcRACUuBugofvNO+tXuF7WOVu 3su0Q0S+6mbVf6Be4zZkuWZ3cuhhpvNowRtgaSxX/LAy4zdO4cqP5NiRq msX3skiqzLWztFopOk477K1Y2aLJx+EJUf+KcPLLlI5/AP2s5V+6iXxMg wvgYOGAP6qciZuZxqiLHwadqawRih3yt4CK5JjY09rrRX76pg2C+pNyOm 2ZrBmVpVZDvnYCytcPum4OqZ4oyro7ADj6oMrglLbZBjsx7+C2hm4J11M uJfxNnvosMkN1yjPjBrymQVA/D8rM/pahSU+FYUNR/BjurABEg3iyKOd2 Q==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="225113375" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:30:00 +0800 IronPort-SDR: 7dZArH0qIzxQhR8XYJEqQIkmLbm0wKNDs+5XVCxT3Ba+eBf1UZW04uxHoz03JF4m+4FB2WrOGS NOj1rOY/NT8xq4rrjFmn45cuHOSV3wWwePqokA3PasRgmtCTV16mtZ3eCB/WcwF8fmgqXc4sKf iO7NgN1O2e2XGG+RH5C/SKijPYSFZ5NXXll7PMkMJzIsbgx6wipopDAnAD04gYIQmBDTUSN2/X 3UbRMuvNCltf+X015z5NLh8PTFdlOa7i7pDDJHO/kssDGiCDbP56vZuMN4rgKe9K5eY5j8HlZ8 a8Q= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:40:29 -0700 IronPort-SDR: tIxHaaZrMsaH1iUS2ggf+8pVfNcR/grCOrrj7g/5URyOMTIIF0fZijKBVGpRBSKPeYjf+qD+o3 gtUtCYKhnkapnZgnYXCNCxVXFQnN/B2tEymJOndFxWJtendlfXxeQRLaB+zpohUrx9Vfnc1q2q DgtMqBaXYhUgOqiNFTwdgqD/0D1FIt7lgRFpUgkuCYXcYj8cXKYm3BAjL5uniHLXalfp0IUXLR oCav6nhOxuwjQoChroloTvYXJ7eZ3Fv/cLn8EdHAtpBB8V5Gx6c8bwC2GweTSogiuO0JKgpW4b 4G0= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:30:00 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2pJ0k2kz1RtVt for ; Wed, 29 Mar 2023 16:30:00 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132599; x=1682724600; bh=/Y/8nFwSzVjprTaZ9/Wyk96kEMW0qhqMfVV hpdupNbM=; b=attI7Cb1FiJUfGooWKuUBF69nVtx8C0v6ZnYPU/aallwnH131e8 koFS+onmiGvEVL5Rsy8MD8W84BqTFny7oW+UX3Q0EgmJyd7MjsjVGq5Fag+o00/p kBXyOu8rVI1MppDWnwv1nSsJjZgW3+f/JtpOKGfbDSqhjxMshlz8soCSdqYWdxyR mZbB9MxATuHT290hQKyTcBQsnd1Zs0bx71V0NrVJwmHkHSmV/TllIeaQKFtE+uS6 +2zu64x2THYHjMlElnTspmwc+eMYbDW16URD8fpUN8smUWhlgc3H2/33t07voR+F ONOgbvSndu0231MHqn3BP6ebhDrfi+c2eNQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id j5jIK7qygF-i for ; Wed, 29 Mar 2023 16:29:59 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2pD1Xt9z1RtVm; Wed, 29 Mar 2023 16:29:56 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:29:55 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 02/19] drbd: use __bio_add_page to add page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <87d0bf7d65cb7c64a0010524e5b39466f2b79870.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <87d0bf7d65cb7c64a0010524e5b39466f2b79870.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 3/30/23 02:05, Johannes Thumshirn wrote: > The drbd code only adds a single page to a newly created bio. So use > __bio_add_page() to add the page which is guaranteed to succeed in this > case. > > This brings us closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn With Matthew comment addressed, Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research