From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-fsdevel@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
Al Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] fs: affs: fix a memory leak in affs_remount
Date: Mon, 30 Sep 2019 08:02:53 +0200 [thread overview]
Message-ID: <ec7d3fdb-445b-7f4e-d6e6-77c6ae9a5732@web.de> (raw)
In-Reply-To: <20190930032200.30474-1-navid.emamdoost@gmail.com>
* Please avoid typos in the commit message.
* I would prefer an other wording for the change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=97f9a3c4eee55b0178b518ae7114a6a53372913d#n151
> But this is not actually used later!
Can this information trigger the deletion of questionable source code
instead of adding a missing function call “kfree(new_opts)”?
How do you think about to add the tag “Fixes”?
Regards,
Markus
next prev parent reply other threads:[~2019-09-30 6:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 3:21 [PATCH] fs: affs: fix a memroy leak in affs_remount Navid Emamdoost
2019-09-30 6:02 ` Markus Elfring [this message]
2019-09-30 21:01 ` [PATCH v2] fs: affs: fix a memory " Navid Emamdoost
2019-10-01 8:30 ` Markus Elfring
2019-10-01 17:34 ` Navid Emamdoost
2019-10-02 5:09 ` [v2] " Markus Elfring
2019-10-02 5:09 ` Markus Elfring
2019-10-02 9:22 ` [PATCH v2] " David Sterba
2019-10-02 16:59 ` Navid Emamdoost
2019-10-02 21:52 ` [PATCH v3] " Navid Emamdoost
2019-10-30 11:44 ` David Sterba
2019-09-30 21:01 ` [PATCH] " Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec7d3fdb-445b-7f4e-d6e6-77c6ae9a5732@web.de \
--to=markus.elfring@web.de \
--cc=deepa.kernel@gmail.com \
--cc=dsterba@suse.com \
--cc=emamd001@umn.edu \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).