From: Bart Van Assche <bvanassche@acm.org>
To: Keith Busch <kbusch@fb.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Cc: axboe@kernel.dk, Kernel Team <Kernel-team@fb.com>,
hch@lst.de, damien.lemoal@opensource.wdc.com,
ebiggers@kernel.org, pankydev8@gmail.com,
Keith Busch <kbusch@kernel.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCHv6 06/11] block/merge: count bytes instead of sectors
Date: Fri, 22 Jul 2022 14:57:33 -0700 [thread overview]
Message-ID: <ed4e63b3-3fd3-ba78-ebd0-69034f703032@acm.org> (raw)
In-Reply-To: <20220610195830.3574005-7-kbusch@fb.com>
On 6/10/22 12:58, Keith Busch wrote:
> @@ -269,8 +269,8 @@ static struct bio *blk_bio_segment_split(struct request_queue *q,
> {
> struct bio_vec bv, bvprv, *bvprvp = NULL;
> struct bvec_iter iter;
> - unsigned nsegs = 0, sectors = 0;
> - const unsigned max_sectors = get_max_io_size(q, bio);
> + unsigned nsegs = 0, bytes = 0;
> + const unsigned max_bytes = get_max_io_size(q, bio) << 9;
How about using SECTOR_SHIFT instead of 9?
Thanks,
Bart.
prev parent reply other threads:[~2022-07-22 21:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220610195830.3574005-1-kbusch@fb.com>
[not found] ` <20220610195830.3574005-8-kbusch@fb.com>
2022-06-13 14:22 ` [PATCHv6 07/11] block/bounce: count bytes instead of sectors Christoph Hellwig
2022-07-22 22:01 ` Bart Van Assche
2022-07-25 14:46 ` Keith Busch
2022-06-13 21:22 ` [PATCHv6 00/11] direct-io dma alignment Jens Axboe
[not found] ` <20220610195830.3574005-12-kbusch@fb.com>
2022-06-23 18:29 ` [PATCHv6 11/11] iomap: add support for dma aligned direct-io Eric Farman
2022-06-23 18:51 ` Keith Busch
2022-06-23 19:11 ` Keith Busch
2022-06-23 20:32 ` Eric Farman
2022-06-23 21:34 ` Eric Farman
2022-06-27 15:21 ` Eric Farman
2022-06-27 15:36 ` Keith Busch
2022-06-28 9:00 ` Halil Pasic
2022-06-28 15:20 ` Eric Farman
2022-06-29 3:18 ` Eric Farman
2022-06-29 3:52 ` Keith Busch
2022-06-29 18:04 ` Eric Farman
2022-06-29 19:07 ` Keith Busch
2022-06-29 19:28 ` Eric Farman
2022-06-30 5:45 ` Christian Borntraeger
2022-07-22 7:36 ` Eric Biggers
2022-07-22 14:43 ` Keith Busch
2022-07-22 18:01 ` Eric Biggers
2022-07-22 20:26 ` Keith Busch
2022-07-25 18:19 ` Eric Biggers
2022-07-24 2:13 ` Jaegeuk Kim
2022-07-22 17:53 ` Darrick J. Wong
2022-07-22 18:12 ` Eric Biggers
2022-07-23 5:03 ` Darrick J. Wong
[not found] ` <20220610195830.3574005-6-kbusch@fb.com>
2022-07-22 21:53 ` [PATCHv6 05/11] block: add a helper function for dio alignment Bart Van Assche
[not found] ` <20220610195830.3574005-7-kbusch@fb.com>
2022-07-22 21:57 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed4e63b3-3fd3-ba78-ebd0-69034f703032@acm.org \
--to=bvanassche@acm.org \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).