From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:49938 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731655AbeGQOZr (ORCPT ); Tue, 17 Jul 2018 10:25:47 -0400 Subject: Re: [PATCH 1/1] iomap: simplify header file include guard macro definition To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org References: <1531724836-7944-1-git-send-email-shan.hai@oracle.com> <20180717131349.GB13582@lst.de> From: Shan Hai Message-ID: Date: Tue, 17 Jul 2018 21:52:44 +0800 MIME-Version: 1.0 In-Reply-To: <20180717131349.GB13582@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2018年07月17日 21:13, Christoph Hellwig wrote: > On Mon, Jul 16, 2018 at 03:07:16PM +0800, Shan Hai wrote: >> The simple definition of a macro is enough for the include guard, it's not >> necessary to assign a value to it, so remove the assignment. >> >> Signed-off-by: Shan Hai > And what is the exact benefit of changing this? The guard macro definition looks consistent with others, that's all :) Thanks Shan Hai