From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kees Cook <kees@kernel.org>, David Sterba <dsterba@suse.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] fs/affs: struct affs_data_head: Replace 1-element array with flexible array
Date: Wed, 10 Jul 2024 17:25:08 -0600 [thread overview]
Message-ID: <ee3b7adb-0f11-4650-ad1f-afc9dceedc8a@embeddedor.com> (raw)
In-Reply-To: <20240710225725.work.409-kees@kernel.org>
On 10/07/24 16:57, Kees Cook wrote:
> Replace the deprecated[1] use of a 1-element array in
> struct affs_data_head with a modern flexible array.
>
> No binary differences are present after this conversion.
>
> Link: https://github.com/KSPP/linux/issues/79 [1]
> Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> Cc: David Sterba <dsterba@suse.com>
> Cc: linux-fsdevel@vger.kernel.org
> ---
> fs/affs/amigaffs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/affs/amigaffs.h b/fs/affs/amigaffs.h
> index 09dc23a644df..1b973a669d23 100644
> --- a/fs/affs/amigaffs.h
> +++ b/fs/affs/amigaffs.h
> @@ -119,7 +119,7 @@ struct affs_data_head
> __be32 size;
> __be32 next;
> __be32 checksum;
> - u8 data[1]; /* depends on block size */
> + u8 data[]; /* depends on block size */
> };
>
> /* Permission bits */
prev parent reply other threads:[~2024-07-10 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 22:57 [PATCH] fs/affs: struct affs_data_head: Replace 1-element array with flexible array Kees Cook
2024-07-10 23:25 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3b7adb-0f11-4650-ad1f-afc9dceedc8a@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=dsterba@suse.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox