From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776C7C77B75 for ; Wed, 10 May 2023 01:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234919AbjEJBKp (ORCPT ); Tue, 9 May 2023 21:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjEJBKo (ORCPT ); Tue, 9 May 2023 21:10:44 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F59049C1; Tue, 9 May 2023 18:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=n2OhR/8mqrfmCbzZz2bw4Ksr3yVT2zjV2VuBFia7p0M=; b=3gduoDpVeCKaG6IgJCxOVeZWee PCg7JZnh3Qo24BhIaWRQpLstjtCLm1uTC8v9odGmPJzmXEvsO/uGVA1IFFNz0IIdFCy7XFeDtv9mC wbnyQbVRS8VUYsO8xUZBrnRkudgWTWeLnVsOPkvQH10ADrFMt0I3OA4t6JG7kFDNNNdhBtgzQOvW/ 13STx74ghdMZMaE38YvYCWeIea740XYs9boIiQejTYPkGtyUqXRDgI2Lj+EKI4PXUtHwUKA6x+a5I CIh2bvm6SVR4aBWz5BKWysfgJvQRlmvqS2Z8axLbMu/p5wVEnuslHAMDNcayhb1guBzMkdIOCfmVR pNKLCkjw==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pwYLo-004fBx-2i; Wed, 10 May 2023 01:10:40 +0000 Message-ID: Date: Tue, 9 May 2023 18:10:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 15/32] bcache: move closures to lib/ Content-Language: en-US To: Kent Overstreet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org Cc: Kent Overstreet , Coly Li References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-16-kent.overstreet@linux.dev> From: Randy Dunlap In-Reply-To: <20230509165657.1735798-16-kent.overstreet@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 5/9/23 09:56, Kent Overstreet wrote: > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 39d1d93164..3dba7a9aff 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1618,6 +1618,15 @@ config DEBUG_NOTIFIERS > This is a relatively cheap check but if you care about maximum > performance, say N. > > +config DEBUG_CLOSURES > + bool "Debug closures (bcache async widgits)" > + depends on CLOSURES > + select DEBUG_FS > + help > + Keeps all active closures in a linked list and provides a debugfs > + interface to list them, which makes it possible to see asynchronous > + operations that get stuck. According to coding-style.rst, the help text (3 lines above) should be indented with 2 additional spaces. > + help > + Keeps all active closures in a linked list and provides a debugfs > + interface to list them, which makes it possible to see asynchronous > + operations that get stuck. -- ~Randy