From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57FA91A29A for ; Tue, 1 Jul 2025 12:50:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751374203; cv=none; b=uG5WpE10gwqui3XSVorPYi2xbM3uULBWRbFqQM6MhIq+/IF8wMN336lS7/puDr5RyzdTToqcBDJ8m770/2YnwEJ+hDKZM68RK/n2+fAiJXop9UdZ3SQHXkW9eWGt1MftJUox3GFZS9n2CanIEEDBWPJfVB83Pq70kOvR2W/V4hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751374203; c=relaxed/simple; bh=JClbjtfLGzwzJZ3cpZLIXHMkfjNwuXuOTK+9mkC+xfI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dr2M6ui4U+KdQlQVwEppz/bS5C4t54eKRYK/BEnuywBDujdFA4XOMGGbKlHgTsClbRVVENO5fJQIk9xdNzdpNd8hH+otYA5wzT+eeOEs3KLwgiPRsgLLFngUEQO/fsDoHVRx7HVy88CKTEH6LkWhYWJtSD8xJyyfblqMuS2q7sE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XTo4bSvk; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XTo4bSvk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751374199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=C+eeNIGph/RfboTkvhQ0KJF1oXksncRWcmuBP7S2QrE=; b=XTo4bSvkQsy1swqkXy42nf7K+gcNEruDIl971R0cYcfJriwF89nGpWW/eeHP7Ewb9YYnlg apxUYr1zAFsS2q7hc0HRIUKnZDI1IsdPXLIlqOKUIFjcgMrW1YZPpXrE8V0M2IE0FJZzjY zSduNpOq61RUS5+bMCmL06R6vkYWhDU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-79-6mxdcFadNECQIzF2MUwwTQ-1; Tue, 01 Jul 2025 08:49:58 -0400 X-MC-Unique: 6mxdcFadNECQIzF2MUwwTQ-1 X-Mimecast-MFC-AGG-ID: 6mxdcFadNECQIzF2MUwwTQ_1751374197 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f858bc5eso2394204f8f.0 for ; Tue, 01 Jul 2025 05:49:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751374197; x=1751978997; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=C+eeNIGph/RfboTkvhQ0KJF1oXksncRWcmuBP7S2QrE=; b=bA1VLnAUVxTRdo50JH6bDIWCorD+yLnLBfRBRqdEE3PhEEmy0C3LPUcHaZu84QhQnQ M4vBVrx+iK3PCrwNdzdLg+ENTlZP/zAc+1JQmVza0s5VEfIlHI5olNZ1JHMmKT8zRKst SPEJx5yYDlyHzRbf+9noI8A6wSZp88dolP/g964Sa3ae0Ck6fGgnRyzfgkUkoeaEIl+w AAhFibmP1qMc3bz9b0su173ogxpt4ODrvaBlwiW0wLUJx+VTD1VIHC76q78wwUDNpiVl 23Q8gjShEjaRQ5QNsrARM9+NOrJqR7VH4d+7Cit9Z+fj6GClkGT1GUnmDF6q/PNyszAY 71cg== X-Forwarded-Encrypted: i=1; AJvYcCUIl5hcD7zj59Zjbejv36YDh3gTiwONZPnSkqcc/XU67knw0lWb86AvTFUTEB49VpDM267nVxXhiQNzxlNJ@vger.kernel.org X-Gm-Message-State: AOJu0YwhrznDrvqNYt92Kf4xt8HRAbVDZ1sT7GF7OvY5LABli4m1R7Yu h2OR65hS5QspiNTgEuuH30hVaK9SEE3JLylGXN8/rupPJ1I1O3OPH2iZ2pYTU64Gb7USOPKYGSI rmY5EYNim58mw8R+ZnfAa6ddgiL0FYK1D6fJmpD3vaLztiCyqiGIzWYyDIV9miJQJawk= X-Gm-Gg: ASbGncvb3FI++mrjVsQzAUBb19ibVDPqHD4cUeBWJAAmeXlXu0j41ejM26m/BnGMlQ7 0z3Zu4HES8e9phTnwPgaEzDdxLb1HMjdiObqdGR74wBJ8znNrHHMA1+q3y5ieXSxGCcNS25HkFz 7LcbXipYJ4i2PgRrzibOpOULssUdh0dtBIHe1CwoFTlga73iJRQ4U4FWRnA4kPOG0K9ffko8lEm AdnBdhmp+dj+B2dpa23JRyoMxlGHY86453OiZNGoXYoDX+rP2YWH+cPV4ZROZPuq7lkXvi1qJhW Z76b6iypRugbRiXquSoHRBTflgLC9/doN7OxVBu2Iy9GUkroOwZkJ3GV/plIkK9RXSxrr2DV0Uc OaAqUjB51B4uhScg1n878y9YJWnzKxGYRG8DdeLgcJJWsFq9Bpg== X-Received: by 2002:adf:979c:0:b0:3a6:e6c3:6d95 with SMTP id ffacd0b85a97d-3a8fe5b1b18mr10836923f8f.41.1751374196718; Tue, 01 Jul 2025 05:49:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAxFPpLtFvUGf5RCxIdMcSORQzf+JZ0BcoaG83ZHXzVCGagtBTeeRvpO+7s2vJcmdXsJSXFQ== X-Received: by 2002:adf:979c:0:b0:3a6:e6c3:6d95 with SMTP id ffacd0b85a97d-3a8fe5b1b18mr10836894f8f.41.1751374196190; Tue, 01 Jul 2025 05:49:56 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7facf9sm13066611f8f.22.2025.07.01.05.49.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 05:49:55 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 14:49:53 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 20/29] mm: convert "movable" flag in page->mapping to a page flag To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-21-david@redhat.com> <0150bc5a-1275-4205-8d85-82364ecabbda@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <0150bc5a-1275-4205-8d85-82364ecabbda@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.07.25 14:44, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 03:00:01PM +0200, David Hildenbrand wrote: >> Instead, let's use a page flag. As the page flag can result in >> false-positives, glue it to the page types for which we >> support/implement movable_ops page migration. >> >> The flag reused by PageMovableOps() might be sued by other pages, so > > I assume 'used' not 'sued' :P :) > >> warning in case it is set in page_has_movable_ops() might result in >> false-positive warnings. > > Worth mentioning that it's PG_uptodate. Also probably worth putting a proviso > here that we're safe to use it for movable ops pages because it's used to track > file system state. Will do. > >> >> Reviewed-by: Zi Yan >> Signed-off-by: David Hildenbrand > > Seems reasonable though, so: > > Reviewed-by: Lorenzo Stoakes Thanks! -- Cheers, David / dhildenb