From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: "leocstone@gmail.com" <leocstone@gmail.com>,
"jack@suse.cz" <jack@suse.cz>,
"penguin-kernel@I-love.SAKURA.ne.jp"
<penguin-kernel@I-love.SAKURA.ne.jp>,
"willy@infradead.org" <willy@infradead.org>,
"brauner@kernel.org" <brauner@kernel.org>
Cc: "glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"slava@dubeyko.com" <slava@dubeyko.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: RE: [PATCH v4] hfs: update sanity check of the root record
Date: Thu, 31 Jul 2025 18:03:22 +0000 [thread overview]
Message-ID: <f0580422d0d8059b4b5303e56e18700539dda39a.camel@ibm.com> (raw)
In-Reply-To: <57d65c2f-ca35-475d-b950-8fd52b135625@I-love.SAKURA.ne.jp>
On Thu, 2025-07-31 at 07:02 +0900, Tetsuo Handa wrote:
> On 2025/07/31 4:24, Viacheslav Dubeyko wrote:
> > If we considering case HFS_CDR_DIR in hfs_read_inode(), then we know that it
> > could be HFS_POR_CNID, HFS_ROOT_CNID, or >= HFS_FIRSTUSER_CNID. Do you mean that
> > HFS_POR_CNID could be a problem in hfs_write_inode()?
>
> Yes. Passing one of 1, 5 or 15 instead of 2 from hfs_fill_super() triggers BUG()
> in hfs_write_inode(). We *MUST* validate at hfs_fill_super(), or hfs_read_inode()
> shall have to also reject 1, 5 and 15 (and as a result only accept 2).
The fix should be in hfs_read_inode(). Currently, suggested solution hides the
issue but not fix the problem. Because b-tree nodes could contain multiple
corrupted records. Now, this patch checks only record for root folder. Let's
imagine that root folder record will be OK but another record(s) will be
corrupted in such way. Finally, we will have successful mount but operation with
corrupted record(s) will trigger this issue. So, I cannot consider this patch as
a complete fix of the problem.
Thanks,
Slava.
next prev parent reply other threads:[~2025-07-31 18:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 13:32 [PATCH] hfs: don't use BUG() when we can continue Tetsuo Handa
2024-12-05 13:45 ` [PATCH (REPOST)] " Tetsuo Handa
2024-12-05 13:59 ` Matthew Wilcox
2024-12-05 14:14 ` Tetsuo Handa
2025-06-25 5:03 ` Tetsuo Handa
2025-07-15 6:51 ` [PATCH v2] hfs: remove BUG() from hfs_release_folio()/hfs_test_inode()/hfs_write_inode() Tetsuo Handa
2025-07-15 19:20 ` Viacheslav Dubeyko
2025-07-17 15:30 ` Tetsuo Handa
2025-07-17 15:32 ` [PATCH v3] " Tetsuo Handa
2025-07-17 18:25 ` Viacheslav Dubeyko
2025-07-17 19:35 ` Matthew Wilcox
2025-07-17 19:49 ` Viacheslav Dubeyko
2025-07-17 22:08 ` Tetsuo Handa
2025-07-21 17:04 ` Viacheslav Dubeyko
2025-07-22 10:42 ` Tetsuo Handa
2025-07-22 13:30 ` Matthew Wilcox
2025-07-22 14:04 ` Tetsuo Handa
2025-07-22 14:22 ` Matthew Wilcox
2025-07-22 18:08 ` Viacheslav Dubeyko
2025-07-23 1:07 ` Tetsuo Handa
2025-07-23 2:16 ` Tetsuo Handa
2025-07-23 18:19 ` Viacheslav Dubeyko
2025-07-23 18:43 ` Viacheslav Dubeyko
2025-07-24 6:55 ` Tetsuo Handa
2025-07-24 19:49 ` Viacheslav Dubeyko
2025-07-24 22:05 ` Tetsuo Handa
2025-07-24 23:20 ` Tetsuo Handa
2025-07-25 4:16 ` Tetsuo Handa
2025-07-25 17:47 ` Viacheslav Dubeyko
2025-07-25 21:52 ` Tetsuo Handa
2025-07-28 19:37 ` Viacheslav Dubeyko
2025-07-28 21:38 ` Tetsuo Handa
2025-07-29 23:21 ` [PATCH v4] hfs: update sanity check of the root record Tetsuo Handa
2025-07-30 19:24 ` Viacheslav Dubeyko
2025-07-30 22:02 ` Tetsuo Handa
2025-07-31 18:03 ` Viacheslav Dubeyko [this message]
2025-07-31 21:12 ` Tetsuo Handa
2025-08-01 18:26 ` Viacheslav Dubeyko
2025-08-01 21:52 ` Tetsuo Handa
2025-08-04 22:00 ` Viacheslav Dubeyko
2025-08-21 10:57 ` Tetsuo Handa
2025-07-25 17:45 ` [PATCH v3] hfs: remove BUG() from hfs_release_folio()/hfs_test_inode()/hfs_write_inode() Viacheslav Dubeyko
2025-07-25 22:25 ` Tetsuo Handa
2025-07-27 13:27 ` Tetsuo Handa
2025-07-25 17:42 ` Viacheslav Dubeyko
2025-07-25 22:22 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0580422d0d8059b4b5303e56e18700539dda39a.camel@ibm.com \
--to=slava.dubeyko@ibm.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jack@suse.cz \
--cc=leocstone@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=slava@dubeyko.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).