From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Robert Rappaport" Subject: Re: File system awareness (or lack thereof) of vfs granting of leases Date: Tue, 20 Feb 2007 16:57:50 -0500 Message-ID: References: <45D6937A.10902@redhat.com> <20070218063948.GC22022@fieldses.org> <20070220163339.GA342@fieldses.org> <40575.141.211.133.169.1172006056.squirrel@www.fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Wendy Cheng" , linux-fsdevel@vger.kernel.org To: "bfields@fieldses.org" Return-path: Received: from nf-out-0910.google.com ([64.233.182.189]:21705 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030473AbXBTV5w (ORCPT ); Tue, 20 Feb 2007 16:57:52 -0500 Received: by nf-out-0910.google.com with SMTP id o25so11403nfa for ; Tue, 20 Feb 2007 13:57:51 -0800 (PST) In-Reply-To: <40575.141.211.133.169.1172006056.squirrel@www.fieldses.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 2/20/07, bfields@fieldses.org wrote: > "Robert Rappaport" said: > > After looking more carefully at your changes, I have a question. Why > > didn't you modify the linux kernel routine, setlease(), so that it > > would either call f_op->set_lease() or __setlease()? Instead you > > created a new routine, nfs4_setlease(), and you modified the previous > > calls to setlease() in nfs4 to now call nfs4_setlease. > > No good reason that I can see. I think you're correct that the > ->setlease() call should go into the common code, and by invoked by fcntl > too. That brings up another thing for me. As I envision what I need to do for my problem, what I want in my f_op->set_lease() routine is to do some specific file system work and then I would like to invoke the __setlease() routine also. Currently that routine is defined as static and therefore uncallable from outside. Is it possible to export that routine or at least the functionality currently in that routine? - Robert Rappaport