From: "Robert Rappaport" <robert.rappaport@gmail.com>
To: "Trond Myklebust" <trond.myklebust@fys.uio.no>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org,
David Teigland <teigland@redhat.com>,
nfs@lists.sourceforge.net, Marc Eshel <eshel@almaden.ibm.com>
Subject: Re: [PATCH] locks: provide a file lease method enabling cluster-coherent leases
Date: Wed, 6 Jun 2007 14:43:22 -0400 [thread overview]
Message-ID: <f0a71180706061143t1b4a4374qef319deac727815f@mail.gmail.com> (raw)
In-Reply-To: <1181086828.6108.11.camel@heimdal.trondhjem.org>
[-- Attachment #1.1: Type: text/plain, Size: 1333 bytes --]
It appears that there is agreement that the functionality currently
implemented in __setlease() should be exported, even though the exported
name may not be __setlease().
That is just fine with me.
The question that I have now is when do you think it likely that these
changes get into the released code? I hope that the plan is to get it there
fairly soon.
- Robert Rappaport
On 6/5/07, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> On Tue, 2007-06-05 at 15:56 -0700, Marc Eshel wrote:
> > Hi Bruce,
> > The file system does need to keep the local state up to date, like it
> does
> > with posix locks, so it might need to call __setlease(). The why we had
> it
> > before was that the call to the file system was done from outside of
> > setlease() and the file system was able to call setlease() which is
> > exported. Now that the call to the fs moved into setlease() the file
> > system can not call it anymore so one possible solution would be to
> export
> > __setlease().
> > Marc.
>
> Please just make a vfs_setlease() which has the ability to call down
> into the filesystem and leave the exported setlease() as a generic
> method that can continue to be called by the filesystems themselves (and
> acts as a fallback for vfs_setlease()). That would be closer to the VFS
> naming conventions.
>
> Trond
>
>
[-- Attachment #1.2: Type: text/html, Size: 1697 bytes --]
[-- Attachment #2: Type: text/plain, Size: 286 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
[-- Attachment #3: Type: text/plain, Size: 140 bytes --]
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-06-06 18:43 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 21:40 cluster-coherent leases J. Bruce Fields
2007-05-31 21:40 ` [PATCH] locks: share more common lease code J. Bruce Fields
2007-05-31 21:40 ` [PATCH] locks: provide a file lease method enabling cluster-coherent leases J. Bruce Fields
2007-05-31 21:40 ` [PATCH] gfs2: stop giving out non-cluster-coherent leases J. Bruce Fields
2007-05-31 22:34 ` [PATCH] locks: provide a file lease method enabling cluster-coherent leases Trond Myklebust
2007-06-01 16:53 ` [NFS] " J. Bruce Fields
2007-06-02 17:39 ` Trond Myklebust
2007-06-02 18:09 ` Marc Eshel
2007-06-02 18:21 ` Trond Myklebust
2007-06-04 13:59 ` J. Bruce Fields
2007-06-05 22:04 ` Robert Rappaport
2007-06-05 22:53 ` [NFS] " Trond Myklebust
2007-06-05 22:56 ` Marc Eshel
2007-06-05 23:40 ` Trond Myklebust
2007-06-06 18:43 ` Robert Rappaport [this message]
2007-06-07 14:43 ` [NFS] " Robert Rappaport
2007-06-07 17:05 ` J. Bruce Fields
2007-06-08 22:14 ` (no subject) J. Bruce Fields
2007-06-08 22:14 ` (unknown), J. Bruce Fields
[not found] ` <11813408953536-git-send-email->
2007-06-08 22:14 ` [PATCH 1/5] locks: share more common lease code J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
[not found] ` <11813408952518-git-send-email->
2007-06-08 22:14 ` [PATCH 2/5] locks: provide a file lease method enabling cluster-coherent leases J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
[not found] ` <11813408951909-git-send-email->
2007-06-08 22:14 ` [PATCH 3/5] locks: rename lease functions to reflect locks.c conventions J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
[not found] ` <11813408954053-git-send-email->
2007-06-08 22:14 ` [PATCH 4/5] gfs2: stop giving out non-cluster-coherent leases J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
[not found] ` <11813408951694-git-send-email->
2007-06-08 22:14 ` [PATCH 5/5] nfs: disable leases over NFS J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
2007-06-09 14:18 ` [PATCH 4/5] gfs2: stop giving out non-cluster-coherent leases Steven Whitehouse
2007-06-09 16:35 ` Marc Eshel
2007-06-11 9:38 ` Steven Whitehouse
2007-06-11 17:07 ` J. Bruce Fields
2007-06-09 16:56 ` [PATCH 3/5] locks: rename lease functions to reflect locks.c conventions Marc Eshel
2007-06-11 16:53 ` J. Bruce Fields
2007-06-02 18:23 ` [NFS] [PATCH] locks: provide a file lease method enabling cluster-coherent leases Trond Myklebust
2007-06-01 13:14 ` Peter Staubach
2007-06-01 16:44 ` [NFS] " J. Bruce Fields
2007-06-01 17:41 ` Matthew Wilcox
2007-06-01 18:08 ` J. Bruce Fields
2007-05-31 21:51 ` [PATCH] locks: share more common lease code Trond Myklebust
2007-06-01 16:30 ` [NFS] " J. Bruce Fields
2007-06-01 16:36 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0a71180706061143t1b4a4374qef319deac727815f@mail.gmail.com \
--to=robert.rappaport@gmail.com \
--cc=bfields@fieldses.org \
--cc=eshel@almaden.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=teigland@redhat.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).