From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 06/11] iov_iter: overlay struct iovec and ubuf/len
Date: Wed, 29 Mar 2023 13:49:25 -0600 [thread overview]
Message-ID: <f12452c7-0bab-3b5d-024c-6ab76672068f@kernel.dk> (raw)
In-Reply-To: <a0911019-9eb9-bf2a-783d-fe5b5d8a9ec0@kernel.dk>
On 3/29/23 1:42 PM, Jens Axboe wrote:
> On 3/29/23 1:38 PM, Jens Axboe wrote:
>> On 3/29/23 1:30 PM, Linus Torvalds wrote:
>>> On Wed, Mar 29, 2023 at 11:41 AM Jens Axboe <axboe@kernel.dk> wrote:
>>>>
>>>> + struct iovec __ubuf_iovec;
>>>
>>> I think this is the third time I say this: this should be "const struct iovec".
>>
>> Doh sorry, not sure why I keep missing that... But yes, it should, I'll make
>> the edit and actually amend it.
>
> Now I recall why that ended up like that again, during the initial fiddling
> with this. If we leave it const, we get:
>
> CC arch/arm64/kernel/asm-offsets.s
> In file included from ./include/linux/socket.h:8,
> from ./include/linux/compat.h:15,
> from ./arch/arm64/include/asm/ftrace.h:52,
> from ./include/linux/ftrace.h:23,
> from arch/arm64/kernel/asm-offsets.c:12:
> ./include/linux/uio.h: In function ‘iov_iter_ubuf’:
> ./include/linux/uio.h:374:12: error: assignment of read-only location ‘*i’
> 374 | *i = (struct iov_iter) {
> | ^
> make[1]: *** [scripts/Makefile.build:114: arch/arm64/kernel/asm-offsets.s] Error 1
> make: *** [Makefile:1286: prepare0] Error 2
>
> Let me take a closer look at that...
We can get rid of these if we convert the iov_iter initializers to
just assign the members rather than the copy+zero fill. The automatic
zero fill is nice though, in terms of sanity.
--
Jens Axboe
next prev parent reply other threads:[~2023-03-29 19:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 18:40 [PATCHSET v6 0/11] Turn single segment imports into ITER_UBUF Jens Axboe
2023-03-29 18:40 ` [PATCH 01/11] block: ensure bio_alloc_map_data() deals with ITER_UBUF correctly Jens Axboe
2023-03-29 18:40 ` [PATCH 02/11] iov_iter: add iter_iovec() helper Jens Axboe
2023-03-29 18:40 ` [PATCH 03/11] iov_iter: add iter_iov_addr() and iter_iov_len() helpers Jens Axboe
2023-03-29 18:40 ` [PATCH 04/11] iov_iter: remove iov_iter_iovec() Jens Axboe
2023-03-29 18:40 ` [PATCH 05/11] iov_iter: set nr_segs = 1 for ITER_UBUF Jens Axboe
2023-03-29 18:40 ` [PATCH 06/11] iov_iter: overlay struct iovec and ubuf/len Jens Axboe
2023-03-29 19:30 ` Linus Torvalds
2023-03-29 19:38 ` Jens Axboe
2023-03-29 19:42 ` Jens Axboe
2023-03-29 19:49 ` Jens Axboe [this message]
2023-03-29 19:52 ` Linus Torvalds
2023-03-29 19:56 ` Jens Axboe
2023-03-29 19:59 ` Linus Torvalds
2023-03-29 20:01 ` Jens Axboe
2023-03-29 18:40 ` [PATCH 07/11] IB/hfi1: check for user backed iterator, not specific iterator type Jens Axboe
2023-03-29 18:40 ` [PATCH 08/11] IB/qib: " Jens Axboe
2023-03-29 18:40 ` [PATCH 09/11] ALSA: pcm: " Jens Axboe
2023-03-29 18:40 ` [PATCH 10/11] iov_iter: convert import_single_range() to ITER_UBUF Jens Axboe
2023-03-29 18:40 ` [PATCH 11/11] iov_iter: import single vector iovecs as ITER_UBUF Jens Axboe
2023-03-29 19:44 ` [PATCHSET v6 0/11] Turn single segment imports into ITER_UBUF Linus Torvalds
2023-03-29 19:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f12452c7-0bab-3b5d-024c-6ab76672068f@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).