From: Jeff Layton <jlayton@kernel.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 00/11] Remove AS_EIO and AS_ENOSPC
Date: Mon, 09 Jan 2023 10:31:58 -0500 [thread overview]
Message-ID: <f3169d8271751094ed9e7e3393b0433d3ef80e83.camel@kernel.org> (raw)
In-Reply-To: <20230109051823.480289-1-willy@infradead.org>
On Mon, 2023-01-09 at 05:18 +0000, Matthew Wilcox (Oracle) wrote:
> Finish the work of converting every user to the "new" wb_err
> infrastructure. This will clash with Christoph's patch series to remove
> folio_write_one(), so I'll redo this after that patch series goes in.
>
> Matthew Wilcox (Oracle) (11):
> memory-failure: Remove comment referencing AS_EIO
> filemap: Remove filemap_check_and_keep_errors()
> f2fs: Convert f2fs_wait_on_node_pages_writeback() to errseq
> fuse: Convert fuse_flush() to use file_check_and_advance_wb_err()
> page-writeback: Convert folio_write_one() to use an errseq
> filemap: Convert filemap_write_and_wait_range() to use errseq
> filemap: Convert filemap_fdatawait_range() to errseq
> cifs: Remove call to filemap_check_wb_err()
> mm: Remove AS_EIO and AS_ENOSPC
> mm: Remove filemap_fdatawait_range_keep_errors()
> mm: Remove filemap_fdatawait_keep_errors()
>
> block/bdev.c | 8 +--
> fs/btrfs/extent_io.c | 6 +--
> fs/cifs/file.c | 8 ++-
> fs/f2fs/data.c | 2 +-
> fs/f2fs/node.c | 4 +-
> fs/fs-writeback.c | 7 +--
> fs/fuse/file.c | 3 +-
> fs/jbd2/commit.c | 12 ++---
> fs/xfs/scrub/bmap.c | 2 +-
> include/linux/pagemap.h | 23 ++------
> mm/filemap.c | 113 +++++++---------------------------------
> mm/memory-failure.c | 28 ----------
> mm/page-writeback.c | 17 +++---
> 13 files changed, 51 insertions(+), 182 deletions(-)
>
Now that I got my understanding straight about unseen errors, I think
this looks good. I think it'd be best to avoid advancing f_wb_err in
->flush operations but the rest of this looks fine.
You can add this to all but #4 (and that one should be easily fixable).
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2023-01-09 15:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 5:18 [PATCH 00/11] Remove AS_EIO and AS_ENOSPC Matthew Wilcox (Oracle)
2023-01-09 5:18 ` [PATCH 01/11] memory-failure: Remove comment referencing AS_EIO Matthew Wilcox (Oracle)
2023-01-12 8:31 ` Christoph Hellwig
2023-01-09 5:18 ` [PATCH 02/11] filemap: Remove filemap_check_and_keep_errors() Matthew Wilcox (Oracle)
2023-01-09 13:48 ` Jeff Layton
2023-01-09 14:02 ` Matthew Wilcox
2023-01-09 14:31 ` Jeff Layton
2023-01-09 15:02 ` Matthew Wilcox
2023-01-09 5:18 ` [PATCH 03/11] f2fs: Convert f2fs_wait_on_node_pages_writeback() to errseq Matthew Wilcox (Oracle)
2023-01-09 5:18 ` [PATCH 04/11] fuse: Convert fuse_flush() to use file_check_and_advance_wb_err() Matthew Wilcox (Oracle)
2023-01-09 15:25 ` Jeff Layton
2023-01-09 5:18 ` [PATCH 05/11] page-writeback: Convert folio_write_one() to use an errseq Matthew Wilcox (Oracle)
2023-01-09 5:18 ` [PATCH 06/11] filemap: Convert filemap_write_and_wait_range() to use errseq Matthew Wilcox (Oracle)
2023-01-17 2:55 ` kernel test robot
2023-01-09 5:18 ` [PATCH 07/11] filemap: Convert filemap_fdatawait_range() to errseq Matthew Wilcox (Oracle)
2023-01-09 5:18 ` [PATCH 08/11] cifs: Remove call to filemap_check_wb_err() Matthew Wilcox (Oracle)
2023-01-09 14:42 ` Jeff Layton
2023-01-09 15:07 ` Matthew Wilcox
2023-01-09 15:14 ` Jeff Layton
2023-01-09 15:30 ` Matthew Wilcox
2023-01-09 15:43 ` Jeff Layton
2023-01-09 5:18 ` [PATCH 09/11] mm: Remove AS_EIO and AS_ENOSPC Matthew Wilcox (Oracle)
2023-01-09 5:18 ` [PATCH 10/11] mm: Remove filemap_fdatawait_range_keep_errors() Matthew Wilcox (Oracle)
2023-01-09 5:18 ` [PATCH 11/11] mm: Remove filemap_fdatawait_keep_errors() Matthew Wilcox (Oracle)
2023-01-09 15:31 ` Jeff Layton [this message]
2023-01-12 8:30 ` [PATCH 00/11] Remove AS_EIO and AS_ENOSPC Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3169d8271751094ed9e7e3393b0433d3ef80e83.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).