From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B4DC43381 for ; Wed, 27 Feb 2019 03:15:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26515218D3 for ; Wed, 27 Feb 2019 03:15:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=synology.com header.i=@synology.com header.b="IVcFc/j2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729265AbfB0DPD (ORCPT ); Tue, 26 Feb 2019 22:15:03 -0500 Received: from mail.synology.com ([211.23.38.101]:39870 "EHLO synology.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729129AbfB0DPD (ORCPT ); Tue, 26 Feb 2019 22:15:03 -0500 Received: from _ (localhost [127.0.0.1]) by synology.com (Postfix) with ESMTPA id 7423617232D1F; Wed, 27 Feb 2019 11:14:59 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synology.com; s=123; t=1551237300; bh=duCoNlNtKOLuAUXDuixFKP71ZqnT96XQS4irHSRNElg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=IVcFc/j2NcXE2so0Zj5yJTjmQCzLO5F/0bH8k+41rY/th1kmp9DPECDbc/8XXSlbP Tx1+4aE1X4jLpagvKLUayv3YRdva32qi3g7qNAl4cok3yjEgXWIQfZBF15HCt204Jf DcT5bOiMVwKlx7P+IZlA2DAXgksDlAvQrUUeaF+M= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 27 Feb 2019 11:14:59 +0800 From: tchou To: Viacheslav Dubeyko Cc: =?UTF-8?Q?=22=5C=22Ernesto_A=2E=5C=22=22_Fern=C3=A1ndez?= , linux-fsdevel@vger.kernel.org, linux-fsdevel-owner@vger.kernel.org Subject: Re: The question about hfs+ patch (hfsplus: fix BUG on bnode parent update) In-Reply-To: <1551236193.3201.19.camel@slavad-ubuntu-14.04> References: <73216487-9ed5-4492-b7c6-b757fdb3b566@Mail> <20190224004441.hhuakey36t2vvvag@eaf> <1551204111.8087.10.camel@dubeyko.com> <4f5b2f03b81ba97f8c110d05716018d9@synology.com> <1551236193.3201.19.camel@slavad-ubuntu-14.04> Message-ID: X-Sender: tchou@synology.com User-Agent: Roundcube Webmail/1.1.2 X-Synology-MCP-Status: no X-Synology-Spam-Flag: no X-Synology-Spam-Status: score=-0.101, required 6, RCPT_COUNT_THREE 0, FROM_EQ_ENVFROM 0, FREEMAIL_ENVRCPT 0, TO_MATCH_ENVRCPT_ALL 0, RCVD_TLS_ALL 0, RCVD_COUNT_ZERO 0, MIME_GOOD -0.1, URIBL_BLOCKED 0, TAGGED_RCPT 0, __THREADED 0, FREEMAIL_CC 0, __NOT_SPOOFED 0, NO_RECEIVED -0.001, FROM_HAS_DN 0, MID_RHS_MATCH_FROM 0, __KHOP_NO_FULL_NAME 0, TO_DN_SOME 0, __BODY_URI_ONLY 0 X-Synology-Virus-Status: no Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Viacheslav Dubeyko 於 2019-02-27 10:56 寫到: > On Wed, 2019-02-27 at 09:46 +0800, tchou wrote: >> Viacheslav Dubeyko 於 2019-02-27 02:01 寫到: >> > On Tue, 2019-02-26 at 11:32 +0800, tchou wrote: >> >> Ernesto A. Fernández 於 2019-02-24 08:44 寫到: >> >> > >> >> > >> > >> > [skipped] >> > >> >> > > >> >> > > [1] >> >> > > ================================================================= >> >> > > ================================= >> >> > > >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.504049] hfsplus: >> >> > > trying to free free bnode 294912(2) >> >> > > >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.510017] hfsplus: >> >> > > trying to free free bnode 294912(2) >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.515983] hfsplus: >> >> > > trying to free free bnode 294912(2) >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.521949] general >> >> > > protection fault: 0000 [#1] SMP >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.621069] CPU: 1 >> >> > > PID: >> >> > > 18715 Comm: SYNO.FileStatio Tainted: P C O 3.10.102 #15152 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.630308] Hardware >> >> > > name: >> >> > > Synology Inc. DS1517+/Type2 - Board Product Name1, BIOS M.405 >> >> > > 2017/05/09 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.640423] task: >> >> > > ffff8802753fa040 ti: ffff880270880000 task.ti: ffff880270880000 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.648779] RIP: >> >> > > 0010:[] [] >> >> > > hfsplus_bnode_write+0x9e/0x1e0 [hfsplus] >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.659489] RSP: >> >> > > 0018:ffff880270883c18 EFLAGS: 00010202 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.665415] RAX: >> >> > > 0000000000000000 RBX: 0000000000000002 RCX: 000000000000aeff >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.673391] RDX: >> >> > > 0000000000000000 RSI: ffff880270883c56 RDI: db73880000000000 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.681366] RBP: >> >> > > ffff88005f7b1920 R08: 0000000000000002 R09: 0000000000000002 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.689343] R10: >> >> > > ffff88005f7b18d0 R11: 0000000000000002 R12: 0000000000001ffc >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.697310] R13: >> >> > > ffff880270883c56 R14: 0000000000000002 R15: 0000000000000002 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.705286] FS: >> >> > > 00007f4fee0607c0(0000) GS:ffff88027fc40000(0000) >> >> > > knlGS:0000000000000000 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.714322] CS: 0010 >> >> > > DS: >> >> > > 0000 ES: 0000 CR0: 000000008005003b >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.720744] CR2: >> >> > > 00007f4fee05d000 CR3: 0000000247210000 CR4: 00000000001007e0 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.728711] DR0: >> >> > > 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.736687] DR3: >> >> > > 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.744654] Stack: >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.746896] >> >> > > ffff88005f7b18c0 ffff880270883cd0 0000000000001ffc >> >> > > 0000000000001f9c >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.755181] >> >> > > 0000000000000060 000000000000000e ffffffffa05146ff >> >> > > aeff000000000031 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.763468] >> >> > > ffffffffa0516bf9 000000606228c340 ffff880270883cd0 >> >> > > 00000000fffffffe >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.771763] Call >> >> > > Trace: >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.774497] >> >> > > [] ? hfsplus_bnode_write_u16+0x1f/0x30 >> >> > > [hfsplus] >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.782671] >> >> > > [] ? hfsplus_brec_remove+0x129/0x190 [hfsplus] >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.790650] >> >> > > [] ? __hfsplus_delete_attr+0x90/0xf0 [hfsplus] >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.798629] >> >> > > [] ? hfsplus_delete_all_attrs+0x49/0xb0 >> >> > > [hfsplus] >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.806900] >> >> > > [] ? hfsplus_delete_cat+0x1c2/0x2b0 [hfsplus] >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.814782] >> >> > > [] ? hfsplus_unlink+0x1d0/0x1e0 [hfsplus] >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.822277] >> >> > > [] ? __inode_permission+0x1d/0xb0 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.828992] >> >> > > [] ? vfs_unlink+0x8a/0x100 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.835025] >> >> > > [] ? do_unlinkat+0x223/0x230 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.841255] >> >> > > [] ? mntput_no_expire+0x13/0x130 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.847873] >> >> > > [] ? task_work_run+0x9c/0xe0 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.854102] >> >> > > [] ? do_notify_resume+0x61/0x90 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.860624] >> >> > > [] ? fput+0x57/0xb0 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.865978] >> >> > > [] ? system_call_fastpath+0x16/0x1b >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.872884] Code: 48 >> >> > > 63 ca >> >> > > 48 01 cf 48 83 fb 08 0f 83 fd 00 00 00 31 c0 41 f6 c3 04 74 09 8b >> >> > > 06 >> >> > > 89 07 b8 04 00 00 00 41 f6 c3 02 74 0c 0f b7 0c 06 <66> 89 0c 07 >> >> > > 48 8d >> >> > > 40 02 41 83 e3 01 74 07 0f b6 0c 06 88 0c 07 >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.894293] RIP >> >> > > [] hfsplus_bnode_write+0x9e/0x1e0 [hfsplus] >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.902375] RSP >> >> > > >> >> > > >> >> > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.906350] ---[ end >> >> > > trace >> >> > > 0e65d1ee34a1e12e ]--- >> >> > > >> >> > > >> >> > > ================================================================= >> >> > > ================================= >> >> > > >> > >> > >> > Could you please share more details about the environment of the bug? >> > Do you know what operation trigger the bug? How had volume been >> > created? Can you reproduce the issue? >> > >> > It looks like the file deletion operation took place. Do you have any >> > idea what file is under deletion and what features it has? Does this >> > file contain any xattr? >> >> Ok, the following description is my situation. The Linux versions of >> our products are 3.10 and 4.4. >> >> Users may plug-in the external USB drive, whose hfs+ is formatted on >> their macOS device, to our device. They can do all file system >> operations(etc create, remove, rename files, and so on) on both >> macOS side and Linux side. >> >> The files created on macOS have the default xattr: >> com.apple.FinderInfo=0sAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKrmU= >> The files created on Linux have no xattr. >> >> Some users seem enconter the call trace when removing the file on >> our device.And it will stock when we unmount it and cause the >> unmount fail. >> >> We cannot reproduce it by ourselves. The following link is the >> only one I can find that have the same situation of mine: >> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1646565/comments/5 >> >> I try some reproduce ways: >> 1. Format the USB drive on Linux and macOS. >> 2. Use fsstress to stress create and unlink operations on Linux. >> 3. Create and remove the 100,000 files on Linux. >> 4. Create 10,000 ~ 500,000 files on MacOS and remove all on Linux. >> All of ways failed. >> >> There are about 10+ users enconter this situation so I try to fix it. >> Any Idea about it? > > OK. I see the point. Let's achieve the stable reproduction of the issue > at first. The issue is triggered by operations in the Attributes Tree > but not in the Catalog Tree. So, it will be enough to create the > several > files. The key trick is to create many xattrs for one file. It will be > better to create xattrs by native way under Macx OS X. I believe that > Attributes Tree's node size could be about 8 KB by default (but maybe 4 > KB only). It is better to check the size in superblock's dump, for > example. So, it needs to create a lot of xattrs for one file (or > several > files) with the goal to create the Attributes Tree with enough number > of > nodes. The best case will be to create the Attributes Tree with height > of 2 or 3 with the goal to have the index nodes too. As far as I can > judge, the issue can be reproduce during the deletion of the xattrs or > file with xattrs under Linux. And it needs to have the Attributes Tree > with many nodes because the issue should be triggered during the > operation of the b-tree node deletion. > > So, I hope my vision could help. Could you please try to reproduce the > issue and to share the results? Thanks for your advice! I will try to reproduce it. And we have a four-day vacations in our country from tomorrow on. I will try it at 3/4 ~ 3/5. Please forgive the delay. > > Thanks, > Vyacheslav Dubeyko.