From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga03-in.huawei.com ([119.145.14.66]:10984 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261AbcIXBCU (ORCPT ); Fri, 23 Sep 2016 21:02:20 -0400 Subject: Re: [PATCH] f2fs: remove dirty inode pages in error path To: Jaegeuk Kim , , , References: <20160923211105.20848-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Sat, 24 Sep 2016 09:02:02 +0800 MIME-Version: 1.0 In-Reply-To: <20160923211105.20848-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2016/9/24 5:11, Jaegeuk Kim wrote: > When getting EIO while handling orphan inodes, we can get some dirty node > pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try > to flush node pages. But in this case, we should prevent to do that, since > we will try again from the start. We are protected since we set SBI_POR_DOING flag in sb, so we are safe now? Thanks,