From: Markus Elfring <Markus.Elfring@web.de>
To: Enrico Weigelt <lkml@metux.net>, linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: fs/seq_file: Replace a seq_printf() call by seq_puts() in seq_hex_dump()
Date: Wed, 3 Jul 2019 13:01:30 +0200 [thread overview]
Message-ID: <f62fdb13-59b7-4e5d-b64a-37b96b5c0125@web.de> (raw)
In-Reply-To: <10744a9b-1c15-1581-8422-bbbf995c0da3@metux.net>
> Looks good,
Thanks for your feedback.
> but have you checked whether "m" could ever be NULL
I wonder about this enquiry.
This function parameter should be valid as usual.
Thus it should not be a null pointer under ordinary conditions.
> and whether seq_puts() has a check for that ?
These output functions do not provide an explicit sanity check for their first parameter
so far.
Regards,
Markus
prev parent reply other threads:[~2019-07-03 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 16:38 [PATCH] fs/seq_file: Replace a seq_printf() call by seq_puts() in seq_hex_dump() Markus Elfring
2019-07-03 9:53 ` Enrico Weigelt, metux IT consult
2019-07-03 11:01 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f62fdb13-59b7-4e5d-b64a-37b96b5c0125@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).