From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/5] aio: support for IO polling
Date: Mon, 19 Nov 2018 09:07:23 -0700 [thread overview]
Message-ID: <f6689a04-430c-cd79-cd4d-997e37d4ecb5@kernel.dk> (raw)
In-Reply-To: <20181119133254.GA32705@infradead.org>
On 11/19/18 6:32 AM, Christoph Hellwig wrote:
>
> I just saw the patch that avoids the irq disabling show up in your
> tree this morning. I think we can do even better by using slightly
> lazy lists that are not updated from ->ki_complete context.
I totally agree, it's just a first step. One restriction you added
is that only one task can be on io_getevents at the time for an
io_context, I didn't want to go that far. One issue with that is
that we can find events that are for other io contexts, if you
saw my patch for the stack list, then that's in there too. So you have
to deal with the case where multiple tasks can be completing events for
the same io_context, regardless of whether you try to block that
behavior at io_getevents() entry time.
> Please take a look at the patch below - this replaces patch 3 from
> my previous mail, that is it is on top of what you send to the list
> plus my first two patches.
Thanks, I'll take a look. I'll split out fhe fops change, as that is
indeed how I wanted to get this done ultimately as well, since it's the
only way to support more complicated setups.
--
Jens Axboe
next prev parent reply other threads:[~2018-11-20 2:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 23:53 [PATCHSET 0/5] Support for polled aio Jens Axboe
2018-11-17 23:53 ` [PATCH 1/5] aio: use assigned completion handler Jens Axboe
2018-11-19 8:06 ` Christoph Hellwig
2018-11-17 23:53 ` [PATCH 2/5] aio: fix failure to put the file pointer Jens Axboe
2018-11-19 8:07 ` Christoph Hellwig
2018-11-19 15:39 ` Jens Axboe
2018-11-17 23:53 ` [PATCH 3/5] aio: add iocb->ki_blk_qc field Jens Axboe
2018-11-19 1:59 ` Dave Chinner
2018-11-19 2:59 ` Jens Axboe
2018-11-17 23:53 ` [PATCH 4/5] aio: support for IO polling Jens Axboe
2018-11-19 8:11 ` Christoph Hellwig
2018-11-19 13:32 ` Christoph Hellwig
2018-11-19 16:07 ` Jens Axboe [this message]
2018-11-17 23:53 ` [PATCH 5/5] aio: add support for file based polled IO Jens Axboe
2018-11-19 1:57 ` Dave Chinner
2018-11-19 2:58 ` Jens Axboe
2018-11-19 8:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6689a04-430c-cd79-cd4d-997e37d4ecb5@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).