From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51C073B95EC; Thu, 5 Mar 2026 15:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772722929; cv=none; b=k7vFAK30Jcp0Ylm06cvX+R98vUn84m/3YNOyzRAPw0iKpENgAfF7priT5JdDxNK1XNvjrgX0oXJkK6OIGyv2dunWluBJST5VDQ/wRFokGz0V4cZ1m+oEAgc9gsav2A6C/DfHILrq5fzSf8ZaZtADo3US0gC7gjxhUc0/7SawpxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772722929; c=relaxed/simple; bh=wRgZmhQjr00u6xNwov7+QTN0n9PgF8LRxMXoCLehj2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AjvdQkarulAjvaMn/8DXfQIJJxtXV5nq7EFPgxZCPTfOn0BfmRSu61IJmOtn9MZdqKiiEcE/LNARBdYjv+wzldQn6q8jBa0tBONH82DAdLD7UT9h03ij9jhGB/rPyCnaS/caHFcyPWB4z6/3rsOOZtTvlH82mPXcfWg9lo+bN7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=osfIcpMz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="osfIcpMz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6767AC2BCAF; Thu, 5 Mar 2026 15:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772722929; bh=wRgZmhQjr00u6xNwov7+QTN0n9PgF8LRxMXoCLehj2Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=osfIcpMz9xkEHd1thmcRC7ID5peuXO60NX3dAfXWNx8XuxafCP3huQAqeo0Z50NTL 7WHXGEd9l4SBIO3qFyZSZs51cQDgZ/txEREq+UVMtkAIWHPQdU6rlIkMwasA+X4H1R 0vgTKrOo0sYCn09iGpla9DwhdJK5l6HmDrrqVHFOs3zTPxZNOSLtG7KttSGuKKL7C5 CGHdJwOurKzj6Z9/m8NtjplDD54vC/3JtqBAJaS9/CVLprX6BFPrW616tHCOxrmc4G 1fXwqivYf5kdVG+FCyXb3KTvQbaG5LkGZXWNmjd7ibSYSDapxeuO3BMr8v1Fwg+Yeu JQAA3sGPUYrCQ== Date: Thu, 5 Mar 2026 15:01:55 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Muchun Song , Oscar Salvador , Konstantin Komarov , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Matthew Wilcox , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Jann Horn , Pedro Falcato , Jason Gunthorpe , linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 6/6] tools/testing/vma: add test for vma_flags_test(), vma_desc_test() Message-ID: References: <376a39eb9e134d2c8ab10e32720dd292970b080a.1772704455.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 05, 2026 at 02:52:20PM +0100, David Hildenbrand (Arm) wrote: > On 3/5/26 11:50, Lorenzo Stoakes (Oracle) wrote: > > Now we have helpers which test singular VMA flags - vma_flags_test() and > > vma_desc_test() - add a test to explicitly assert that these behave as > > expected. > > > > Signed-off-by: Lorenzo Stoakes (Oracle) > > --- > > tools/testing/vma/tests/vma.c | 36 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > > > diff --git a/tools/testing/vma/tests/vma.c b/tools/testing/vma/tests/vma.c > > index f031e6dfb474..1aa94dd7e74a 100644 > > --- a/tools/testing/vma/tests/vma.c > > +++ b/tools/testing/vma/tests/vma.c > > @@ -159,6 +159,41 @@ static bool test_vma_flags_word(void) > > return true; > > } > > > > +/* Ensure that vma_flags_test() and friends works correctly. */ > > +static bool test_vma_flags_test(void) > > +{ > > + const vma_flags_t flags = mk_vma_flags(VMA_READ_BIT, VMA_WRITE_BIT, > > + VMA_EXEC_BIT, 64, 65); > > When already using numbers, I was wondering whether you'd want to stick > to numbers only here. Numbers are for flags > 64 bits, we currently don't define any, it's to make sure everything works at higher bitmap sizes, the tests currently set the bitmap size to 128 bits. > > > + struct vm_area_desc desc; > > > struct vm_area_desc desc = { > .vma_flags = flags, > }; > > ? Ack can do, fix-patch for Andrew below :) Cheers, Lorenzo ----8<---- >From 5cc64e6c1884aaf995ce6398e36d5844c246352d Mon Sep 17 00:00:00 2001 From: "Lorenzo Stoakes (Oracle)" Date: Thu, 5 Mar 2026 14:59:58 +0000 Subject: [PATCH] fix Signed-off-by: Lorenzo Stoakes (Oracle) --- tools/testing/vma/tests/vma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/vma/tests/vma.c b/tools/testing/vma/tests/vma.c index 1aa94dd7e74a..f6edd44f4e9e 100644 --- a/tools/testing/vma/tests/vma.c +++ b/tools/testing/vma/tests/vma.c @@ -164,9 +164,9 @@ static bool test_vma_flags_test(void) { const vma_flags_t flags = mk_vma_flags(VMA_READ_BIT, VMA_WRITE_BIT, VMA_EXEC_BIT, 64, 65); - struct vm_area_desc desc; - - desc.vma_flags = flags; + struct vm_area_desc desc = { + .vma_flags = flags, + }; #define do_test(_flag) \ ASSERT_TRUE(vma_flags_test(&flags, _flag)); \ -- 2.53.0