From: Randy Dunlap <rdunlap@infradead.org>
To: Tamir Duberstein <tamird@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] XArray: minor documentation improvements
Date: Thu, 10 Oct 2024 14:34:56 -0700 [thread overview]
Message-ID: <f7fba2fa-cac9-4ecd-98e1-adb2cac474ab@infradead.org> (raw)
In-Reply-To: <20241010141309.52527-2-tamird@gmail.com>
Hi Tamir,
On 10/10/24 7:12 AM, Tamir Duberstein wrote:
> Normal API
> ==========
> @@ -63,13 +64,14 @@ for statically allocated XArrays or xa_init() for dynamically
> allocated ones. A freshly-initialised XArray contains a ``NULL``
> pointer at every index.
>
> -You can then set entries using xa_store() and get entries
> -using xa_load(). xa_store will overwrite any entry with the
> -new entry and return the previous entry stored at that index. You can
> -use xa_erase() instead of calling xa_store() with a
> +You can then set entries using xa_store() and get entries using
> +xa_load(). xa_store() will overwrite any entry with the new entry and
> +return the previous entry stored at that index. You can unset entries
> +using xa_erase() or by setting the entry to ``NULL`` using xa_store().
> ``NULL`` entry. There is no difference between an entry that has never
Is the line above supposed to be here?
Confusing to me.
Thanks.
> -been stored to, one that has been erased and one that has most recently
> -had ``NULL`` stored to it.
> +been stored to and one that has been erased with xa_erase(); an entry
> +that has most recently had ``NULL`` stored to it is also equivalent
> +except if the XArray was initialized with ``XA_FLAGS_ALLOC``.
--
~Randy
next prev parent reply other threads:[~2024-10-10 21:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 19:36 [PATCH] XArray: minor documentation improvements Tamir Duberstein
2024-10-09 20:44 ` Darrick J. Wong
2024-10-09 20:51 ` Tamir Duberstein
2024-10-09 20:52 ` [PATCH v2] " Tamir Duberstein
2024-10-09 21:25 ` Darrick J. Wong
2024-10-09 21:59 ` Jonathan Corbet
2024-10-09 22:16 ` Tamir Duberstein
2024-10-09 22:22 ` Randy Dunlap
2024-10-10 14:11 ` Tamir Duberstein
2024-10-10 14:12 ` [PATCH v3] " Tamir Duberstein
2024-10-10 21:34 ` Randy Dunlap [this message]
2024-10-10 21:39 ` Tamir Duberstein
2024-10-10 21:41 ` [PATCH v4] " Tamir Duberstein
2024-10-10 21:50 ` Randy Dunlap
2024-10-10 22:41 ` Matthew Wilcox
2024-10-16 12:51 ` Tamir Duberstein
2024-10-24 19:52 ` Tamir Duberstein
2024-10-17 0:34 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7fba2fa-cac9-4ecd-98e1-adb2cac474ab@infradead.org \
--to=rdunlap@infradead.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).